* [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
2019-06-12 2:39 [PATCH] CryptoPkg: Add lacking instances for build only Gao, Zhichao
@ 2019-06-12 2:39 ` Gao, Zhichao
2019-06-13 8:03 ` Wu, Hao A
2019-06-12 2:39 ` [PATCH] SecurityPkg: " Gao, Zhichao
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Gao, Zhichao @ 2019-06-12 2:39 UTC (permalink / raw)
To: devel
Cc: Bret Barkelew, Hao A Wu, Liming Gao, Sean Brogan, Michael Turner,
Leif Lindholm, Zhichao gao
From: Bret Barkelew <Bret.Barkelew@microsoft.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
Add the lacking instance to the [Components] of dsc file
for build only.
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
---
SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
index 8be6781296..a1a1b81d03 100644
--- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
+++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
@@ -93,6 +93,8 @@
###################################################################################################
[Components.common]
+ SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.inf
+ SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Pei.inf
SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.inf
SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLibDebug.inf
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
2019-06-12 2:39 ` [PATCH] SourceLevelDebugPkg: " Gao, Zhichao
@ 2019-06-13 8:03 ` Wu, Hao A
2019-06-17 1:23 ` [edk2-devel] " Wu, Hao A
0 siblings, 1 reply; 11+ messages in thread
From: Wu, Hao A @ 2019-06-13 8:03 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io
Cc: Bret Barkelew, Gao, Liming, Sean Brogan, Michael Turner,
Leif Lindholm
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wu, Hao A; Gao, Liming; Sean Brogan; Michael Turner; Leif
> Lindholm; Gao, Zhichao
> Subject: [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
With a similar suggestion at:
https://edk2.groups.io/g/devel/topic/32037312#42319
handled:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
>
> Add the lacking instance to the [Components] of dsc file
> for build only.
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> ---
> SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> index 8be6781296..a1a1b81d03 100644
> --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> @@ -93,6 +93,8 @@
>
> ##########################################################
> #########################################
>
> [Components.common]
> +
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> nicationLibUsb3Dxe.inf
> +
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> nicationLibUsb3Pei.inf
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommun
> icationLibUsb.inf
>
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActio
> nLibDebug.inf
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
2019-06-13 8:03 ` Wu, Hao A
@ 2019-06-17 1:23 ` Wu, Hao A
0 siblings, 0 replies; 11+ messages in thread
From: Wu, Hao A @ 2019-06-17 1:23 UTC (permalink / raw)
To: devel@edk2.groups.io, Wu, Hao A, Gao, Zhichao
Cc: Bret Barkelew, Gao, Liming, Sean Brogan, Michael Turner,
Leif Lindholm
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Thursday, June 13, 2019 4:04 PM
> To: Gao, Zhichao; devel@edk2.groups.io
> Cc: Bret Barkelew; Gao, Liming; Sean Brogan; Michael Turner; Leif Lindholm
> Subject: Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking
> instances for build only
>
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Wednesday, June 12, 2019 10:40 AM
> > To: devel@edk2.groups.io
> > Cc: Bret Barkelew; Wu, Hao A; Gao, Liming; Sean Brogan; Michael Turner;
> Leif
> > Lindholm; Gao, Zhichao
> > Subject: [PATCH] SourceLevelDebugPkg: Add lacking instances for build
> only
>
>
> With a similar suggestion at:
> https://edk2.groups.io/g/devel/topic/32037312#42319
>
> handled:
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Pushed via commit 34857c2ff9.
Best Regards,
Hao Wu
>
> Best Regards,
> Hao Wu
>
>
> >
> > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
> >
> > Add the lacking instance to the [Components] of dsc file
> > for build only.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> > ---
> > SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > index 8be6781296..a1a1b81d03 100644
> > --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > @@ -93,6 +93,8 @@
> >
> >
> ##########################################################
> > #########################################
> >
> > [Components.common]
> > +
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> > nicationLibUsb3Dxe.inf
> > +
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> > nicationLibUsb3Pei.inf
> >
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> > mmunicationLibSerialPort.inf
> >
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommun
> > icationLibUsb.inf
> >
> >
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActio
> > nLibDebug.inf
> > --
> > 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] SecurityPkg: Add lacking instances for build only
2019-06-12 2:39 [PATCH] CryptoPkg: Add lacking instances for build only Gao, Zhichao
2019-06-12 2:39 ` [PATCH] SourceLevelDebugPkg: " Gao, Zhichao
@ 2019-06-12 2:39 ` Gao, Zhichao
2019-06-12 2:39 ` [PATCH] MdeModulePkg: " Gao, Zhichao
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Gao, Zhichao @ 2019-06-12 2:39 UTC (permalink / raw)
To: devel
Cc: Bret Barkelew, Chao Zhang, Jiewen Yao, Jian Wang, Liming Gao,
Sean Brogan, Michael Turner, Leif Lindholm, Zhichao gao
From: Bret Barkelew <Bret.Barkelew@microsoft.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
Add the lacking instance to the [Components] of dsc file
for build only.
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
---
SecurityPkg/SecurityPkg.dsc | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
index a2ee0528f0..ed0da7563d 100644
--- a/SecurityPkg/SecurityPkg.dsc
+++ b/SecurityPkg/SecurityPkg.dsc
@@ -199,6 +199,12 @@
SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
+ SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf
+ SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
+ SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
+ SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf
+ SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf
+
[Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH] MdeModulePkg: Add lacking instances for build only
2019-06-12 2:39 [PATCH] CryptoPkg: Add lacking instances for build only Gao, Zhichao
2019-06-12 2:39 ` [PATCH] SourceLevelDebugPkg: " Gao, Zhichao
2019-06-12 2:39 ` [PATCH] SecurityPkg: " Gao, Zhichao
@ 2019-06-12 2:39 ` Gao, Zhichao
2019-06-13 8:19 ` Wu, Hao A
2019-06-12 8:38 ` [edk2-devel] [PATCH] CryptoPkg: " Laszlo Ersek
2019-06-12 17:05 ` Wang, Jian J
4 siblings, 1 reply; 11+ messages in thread
From: Gao, Zhichao @ 2019-06-12 2:39 UTC (permalink / raw)
To: devel
Cc: Bret Barkelew, Jian J Wang, Hao Wu, Ray Ni, Star Zeng, Liming Gao,
Sean Brogan, Michael Turner
From: Bret Barkelew <Bret.Barkelew@microsoft.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1857
Add the lacking instances to the [Components] of dsc file
for build only.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
MdeModulePkg/MdeModulePkg.dsc | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
index 995fd805e1..f32adc3839 100644
--- a/MdeModulePkg/MdeModulePkg.dsc
+++ b/MdeModulePkg/MdeModulePkg.dsc
@@ -204,6 +204,22 @@
MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.inf
MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf
+ MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
+ MdeModulePkg/Logo/Logo.inf
+ MdeModulePkg/Logo/LogoDxe.inf
+ MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
+ MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
+ MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
+ MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
+ MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
+ MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
+ MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
+ MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.inf
+ MdeModulePkg/Library/PiSmmCoreSmmServicesTableLib/PiSmmCoreSmmServicesTableLib.inf
+ MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
+ MdeModulePkg/Library/BaseHobLibNull/BaseHobLibNull.inf
+ MdeModulePkg/Library/BaseMemoryAllocationLibNull/BaseMemoryAllocationLibNull.inf
+
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf
MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] MdeModulePkg: Add lacking instances for build only
2019-06-12 2:39 ` [PATCH] MdeModulePkg: " Gao, Zhichao
@ 2019-06-13 8:19 ` Wu, Hao A
2019-06-17 1:26 ` [edk2-devel] " Wu, Hao A
0 siblings, 1 reply; 11+ messages in thread
From: Wu, Hao A @ 2019-06-13 8:19 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io
Cc: Bret Barkelew, Wang, Jian J, Ni, Ray, Zeng, Star, Gao, Liming,
Sean Brogan, Michael Turner
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming;
> Sean Brogan; Michael Turner
> Subject: [PATCH] MdeModulePkg: Add lacking instances for build only
There are 224 INF files in MdeModulePkg, and now there are 224 occurrences
when searching '^ MdeModulePkg.+\.inf' in MdeModulePkg.dsc. The number
matches.
Also, seems to me ARM & AARCH64 also build fine.
Then, with a similar suggestion at:
https://edk2.groups.io/g/devel/topic/32037312#42319
handled:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1857
>
> Add the lacking instances to the [Components] of dsc file
> for build only.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> MdeModulePkg/MdeModulePkg.dsc | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dsc
> b/MdeModulePkg/MdeModulePkg.dsc
> index 995fd805e1..f32adc3839 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -204,6 +204,22 @@
> MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.inf
> MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf
>
> + MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> + MdeModulePkg/Logo/Logo.inf
> + MdeModulePkg/Logo/LogoDxe.inf
> + MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> +
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance
> ManagerUiLib.inf
> + MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
> + MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> + MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
> + MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
> + MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
> + MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.inf
> +
> MdeModulePkg/Library/PiSmmCoreSmmServicesTableLib/PiSmmCoreSmmS
> ervicesTableLib.inf
> + MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
> + MdeModulePkg/Library/BaseHobLibNull/BaseHobLibNull.inf
> +
> MdeModulePkg/Library/BaseMemoryAllocationLibNull/BaseMemoryAllocati
> onLibNull.inf
> +
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
> MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf
> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg: Add lacking instances for build only
2019-06-13 8:19 ` Wu, Hao A
@ 2019-06-17 1:26 ` Wu, Hao A
0 siblings, 0 replies; 11+ messages in thread
From: Wu, Hao A @ 2019-06-17 1:26 UTC (permalink / raw)
To: devel@edk2.groups.io, Wu, Hao A, Gao, Zhichao
Cc: Bret Barkelew, Wang, Jian J, Ni, Ray, Zeng, Star, Gao, Liming,
Sean Brogan, Michael Turner
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Thursday, June 13, 2019 4:20 PM
> To: Gao, Zhichao; devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
> Michael Turner
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Add lacking instances for
> build only
>
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Wednesday, June 12, 2019 10:40 AM
> > To: devel@edk2.groups.io
> > Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming;
> > Sean Brogan; Michael Turner
> > Subject: [PATCH] MdeModulePkg: Add lacking instances for build only
>
> There are 224 INF files in MdeModulePkg, and now there are 224
> occurrences
> when searching '^ MdeModulePkg.+\.inf' in MdeModulePkg.dsc. The
> number
> matches.
>
> Also, seems to me ARM & AARCH64 also build fine.
>
> Then, with a similar suggestion at:
> https://edk2.groups.io/g/devel/topic/32037312#42319
>
> handled:
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Pushed via commit 6764fb9cd8.
Best Regards,
Hao Wu
>
> Best Regards,
> Hao Wu
>
>
> >
> > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1857
> >
> > Add the lacking instances to the [Components] of dsc file
> > for build only.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> > MdeModulePkg/MdeModulePkg.dsc | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc
> > index 995fd805e1..f32adc3839 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -204,6 +204,22 @@
> > MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.inf
> > MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf
> >
> > + MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> > + MdeModulePkg/Logo/Logo.inf
> > + MdeModulePkg/Logo/LogoDxe.inf
> > + MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > +
> >
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance
> > ManagerUiLib.inf
> > + MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
> > + MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> > + MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
> > + MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
> > + MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
> > + MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.inf
> > +
> >
> MdeModulePkg/Library/PiSmmCoreSmmServicesTableLib/PiSmmCoreSmmS
> > ervicesTableLib.inf
> > + MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
> > + MdeModulePkg/Library/BaseHobLibNull/BaseHobLibNull.inf
> > +
> >
> MdeModulePkg/Library/BaseMemoryAllocationLibNull/BaseMemoryAllocati
> > onLibNull.inf
> > +
> > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
> > MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf
> > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> > --
> > 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only
2019-06-12 2:39 [PATCH] CryptoPkg: Add lacking instances for build only Gao, Zhichao
` (2 preceding siblings ...)
2019-06-12 2:39 ` [PATCH] MdeModulePkg: " Gao, Zhichao
@ 2019-06-12 8:38 ` Laszlo Ersek
2019-06-13 0:32 ` Gao, Zhichao
2019-06-12 17:05 ` Wang, Jian J
4 siblings, 1 reply; 11+ messages in thread
From: Laszlo Ersek @ 2019-06-12 8:38 UTC (permalink / raw)
To: devel, zhichao.gao
Cc: Bret Barkelew, Jian Wang, Ting Ye, Liming Gao, Sean Brogan,
Michael Turner
On 06/12/19 04:39, Gao, Zhichao wrote:
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1900
>
> Add the lacking instance to [Componnets] of dsc file
> for build only.
>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Ting Ye <ting.ye@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> CryptoPkg/CryptoPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc
> index 9dfa349f6d..c90e76c721 100644
> --- a/CryptoPkg/CryptoPkg.dsc
> +++ b/CryptoPkg/CryptoPkg.dsc
> @@ -116,6 +116,7 @@
> CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> CryptoPkg/Library/TlsLib/TlsLib.inf
> CryptoPkg/Library/OpensslLib/OpensslLib.inf
> + CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
>
> [Components.IA32, Components.X64]
> CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
>
I'd like to suggest wording / spelling improvements:
- [Componnets] should be [Components]
- While I'm not a native English speaker, I believe "missing" would be
more precise than "lacking". To me, "lacking" implies that the library
instances in question have shortcomings. However, that's not what we
mean here -- those library instances are just fine, they are just
missing from the DSC files. Hence my suggestion to say "missing" (in
both the subject line and the commit message).
Thank you
Laszlo
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only
2019-06-12 8:38 ` [edk2-devel] [PATCH] CryptoPkg: " Laszlo Ersek
@ 2019-06-13 0:32 ` Gao, Zhichao
0 siblings, 0 replies; 11+ messages in thread
From: Gao, Zhichao @ 2019-06-13 0:32 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Bret Barkelew, Wang, Jian J, Ye, Ting, Gao, Liming, Sean Brogan,
Michael Turner
I would fix the typo and replace the word 'lacking' with 'missing' in both BZ and the subject.
Thanks,
Zhichao
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 12, 2019 4:38 PM
> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Michael Turner <Michael.Turner@microsoft.com>
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build
> only
>
> On 06/12/19 04:39, Gao, Zhichao wrote:
> > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1900
> >
> > Add the lacking instance to [Componnets] of dsc file for build only.
> >
> > Cc: Jian Wang <jian.j.wang@intel.com>
> > Cc: Ting Ye <ting.ye@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> > CryptoPkg/CryptoPkg.dsc | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc index
> > 9dfa349f6d..c90e76c721 100644
> > --- a/CryptoPkg/CryptoPkg.dsc
> > +++ b/CryptoPkg/CryptoPkg.dsc
> > @@ -116,6 +116,7 @@
> > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> > CryptoPkg/Library/TlsLib/TlsLib.inf
> > CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > + CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> >
> > [Components.IA32, Components.X64]
> > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> >
>
> I'd like to suggest wording / spelling improvements:
>
> - [Componnets] should be [Components]
>
> - While I'm not a native English speaker, I believe "missing" would be more
> precise than "lacking". To me, "lacking" implies that the library instances in
> question have shortcomings. However, that's not what we mean here --
> those library instances are just fine, they are just missing from the DSC files.
> Hence my suggestion to say "missing" (in both the subject line and the
> commit message).
>
> Thank you
> Laszlo
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only
2019-06-12 2:39 [PATCH] CryptoPkg: Add lacking instances for build only Gao, Zhichao
` (3 preceding siblings ...)
2019-06-12 8:38 ` [edk2-devel] [PATCH] CryptoPkg: " Laszlo Ersek
@ 2019-06-12 17:05 ` Wang, Jian J
4 siblings, 0 replies; 11+ messages in thread
From: Wang, Jian J @ 2019-06-12 17:05 UTC (permalink / raw)
To: devel@edk2.groups.io, Gao, Zhichao
Cc: Bret Barkelew, Ye, Ting, Gao, Liming, Sean Brogan, Michael Turner
With the wording/spelling addressed (see Laszlo's comment,
https://edk2.groups.io/g/devel/message/42273),
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Michael
> Turner <Michael.Turner@microsoft.com>
> Subject: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only
>
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1900
>
> Add the lacking instance to [Componnets] of dsc file
> for build only.
>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Ting Ye <ting.ye@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> CryptoPkg/CryptoPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc
> index 9dfa349f6d..c90e76c721 100644
> --- a/CryptoPkg/CryptoPkg.dsc
> +++ b/CryptoPkg/CryptoPkg.dsc
> @@ -116,6 +116,7 @@
> CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> CryptoPkg/Library/TlsLib/TlsLib.inf
> CryptoPkg/Library/OpensslLib/OpensslLib.inf
> + CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
>
> [Components.IA32, Components.X64]
> CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> --
> 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread