From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Ni, Ray" <ray.ni@intel.com>, "Zeng, Star" <star.zeng@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Michael Turner <Michael.Turner@microsoft.com>
Subject: Re: [PATCH] MdeModulePkg: Add lacking instances for build only
Date: Thu, 13 Jun 2019 08:19:37 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8F0296@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190612023956.9180-4-zhichao.gao@intel.com>
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming;
> Sean Brogan; Michael Turner
> Subject: [PATCH] MdeModulePkg: Add lacking instances for build only
There are 224 INF files in MdeModulePkg, and now there are 224 occurrences
when searching '^ MdeModulePkg.+\.inf' in MdeModulePkg.dsc. The number
matches.
Also, seems to me ARM & AARCH64 also build fine.
Then, with a similar suggestion at:
https://edk2.groups.io/g/devel/topic/32037312#42319
handled:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1857
>
> Add the lacking instances to the [Components] of dsc file
> for build only.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> MdeModulePkg/MdeModulePkg.dsc | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dsc
> b/MdeModulePkg/MdeModulePkg.dsc
> index 995fd805e1..f32adc3839 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -204,6 +204,22 @@
> MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.inf
> MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf
>
> + MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> + MdeModulePkg/Logo/Logo.inf
> + MdeModulePkg/Logo/LogoDxe.inf
> + MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> +
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance
> ManagerUiLib.inf
> + MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
> + MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> + MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
> + MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
> + MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
> + MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.inf
> +
> MdeModulePkg/Library/PiSmmCoreSmmServicesTableLib/PiSmmCoreSmmS
> ervicesTableLib.inf
> + MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
> + MdeModulePkg/Library/BaseHobLibNull/BaseHobLibNull.inf
> +
> MdeModulePkg/Library/BaseMemoryAllocationLibNull/BaseMemoryAllocati
> onLibNull.inf
> +
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
> MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf
> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> --
> 2.21.0.windows.1
next prev parent reply other threads:[~2019-06-13 8:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 2:39 [PATCH] CryptoPkg: Add lacking instances for build only Gao, Zhichao
2019-06-12 2:39 ` [PATCH] SourceLevelDebugPkg: " Gao, Zhichao
2019-06-13 8:03 ` Wu, Hao A
2019-06-17 1:23 ` [edk2-devel] " Wu, Hao A
2019-06-12 2:39 ` [PATCH] SecurityPkg: " Gao, Zhichao
2019-06-12 2:39 ` [PATCH] MdeModulePkg: " Gao, Zhichao
2019-06-13 8:19 ` Wu, Hao A [this message]
2019-06-17 1:26 ` [edk2-devel] " Wu, Hao A
2019-06-12 8:38 ` [edk2-devel] [PATCH] CryptoPkg: " Laszlo Ersek
2019-06-13 0:32 ` Gao, Zhichao
2019-06-12 17:05 ` Wang, Jian J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C8F0296@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox