From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Thu, 13 Jun 2019 01:19:41 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 01:19:41 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 13 Jun 2019 01:19:41 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 01:19:41 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 01:19:41 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.83]) with mapi id 14.03.0439.000; Thu, 13 Jun 2019 16:19:39 +0800 From: "Wu, Hao A" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: Bret Barkelew , "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner Subject: Re: [PATCH] MdeModulePkg: Add lacking instances for build only Thread-Topic: [PATCH] MdeModulePkg: Add lacking instances for build only Thread-Index: AQHVIMgwZOseB1dYbEewTg6hsGcPBaaZPVDA Date: Thu, 13 Jun 2019 08:19:37 +0000 Message-ID: References: <20190612023956.9180-1-zhichao.gao@intel.com> <20190612023956.9180-4-zhichao.gao@intel.com> In-Reply-To: <20190612023956.9180-4-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, June 12, 2019 10:40 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Lim= ing; > Sean Brogan; Michael Turner > Subject: [PATCH] MdeModulePkg: Add lacking instances for build only There are 224 INF files in MdeModulePkg, and now there are 224 occurrences when searching '^ MdeModulePkg.+\.inf' in MdeModulePkg.dsc. The number matches. Also, seems to me ARM & AARCH64 also build fine. Then, with a similar suggestion at: https://edk2.groups.io/g/devel/topic/32037312#42319 handled: Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > From: Bret Barkelew >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1857 >=20 > Add the lacking instances to the [Components] of dsc file > for build only. >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > Signed-off-by: Zhichao Gao > --- > MdeModulePkg/MdeModulePkg.dsc | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc > index 995fd805e1..f32adc3839 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -204,6 +204,22 @@ > MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.inf > MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf >=20 > + MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > + MdeModulePkg/Logo/Logo.inf > + MdeModulePkg/Logo/LogoDxe.inf > + MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > + > MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance > ManagerUiLib.inf > + MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > + MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > + MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf > + MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > + MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > + MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.inf > + > MdeModulePkg/Library/PiSmmCoreSmmServicesTableLib/PiSmmCoreSmmS > ervicesTableLib.inf > + MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf > + MdeModulePkg/Library/BaseHobLibNull/BaseHobLibNull.inf > + > MdeModulePkg/Library/BaseMemoryAllocationLibNull/BaseMemoryAllocati > onLibNull.inf > + > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > -- > 2.21.0.windows.1