From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Thu, 13 Jun 2019 17:14:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 17:14:46 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 13 Jun 2019 17:14:46 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 17:14:46 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 17:14:46 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.83]) with mapi id 14.03.0439.000; Fri, 14 Jun 2019 08:14:43 +0800 From: "Wu, Hao A" To: "Yao, Jiewen" , "Zurcher, Christopher J" , "Gao, Liming" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Wang, Jian J" , "Ni, Ray" Subject: Re: [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol Thread-Topic: [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol Thread-Index: AQHVIjfJyZgMjjhRSk2xC0mBFa0iGaaaR6jA Date: Fri, 14 Jun 2019 00:14:43 +0000 Message-ID: References: <20190613020454.19324-1-christopher.j.zurcher@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4809BF@SHSMSX104.ccr.corp.intel.com> <8EE4873E19344F4DA986A2AC15D512AE4613B908@CRSMSX104.amr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F6B2BD5@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F6B2BD5@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Yao, Jiewen > Sent: Friday, June 14, 2019 6:32 AM > To: Zurcher, Christopher J; Gao, Liming; devel@edk2.groups.io > Cc: Kinney, Michael D; Wang, Jian J; Ni, Ray; Wu, Hao A > Subject: RE: [PATCH v4 0/2] Add SCSI Support for Storage Security Command > Protocol >=20 > Thank you Christopher. > Your code looks good to me. >=20 > I also recommend MdeModulePkg/SCSI owner take a look and give r-b. >=20 > Ray or Hao > Can you help on that? Yes, I will take a look. Please grant me some time, will give my feedbacks early next week. Best Regards, Hao Wu >=20 > Thank you > Yao Jiewen >=20 > > -----Original Message----- > > From: Zurcher, Christopher J > > Sent: Friday, June 14, 2019 6:26 AM > > To: Gao, Liming ; devel@edk2.groups.io > > Cc: Kinney, Michael D ; Yao, Jiewen > > ; Wang, Jian J > > Subject: RE: [PATCH v4 0/2] Add SCSI Support for Storage Security > Command > > Protocol > > > > A unit test has been run which provisions RPMB key, writes data, and > verifies > > it after reading on the following boot. > > Further, this code is being exercised for secure storage on multiple > platforms > > as part of standard boot flow. > > > > Unit test files emailed separately. > > > > Thanks, > > Christopher Zurcher > > > > > > -----Original Message----- > > From: Gao, Liming > > Sent: Thursday, June 13, 2019 05:59 > > To: Zurcher, Christopher J ; > > devel@edk2.groups.io > > Cc: Kinney, Michael D ; Yao, Jiewen > > ; Wang, Jian J > > Subject: RE: [PATCH v4 0/2] Add SCSI Support for Storage Security > Command > > Protocol > > > > Zurcher: > > Can you share what test has been done for this feature? > > > > Thanks > > Liming > > > -----Original Message----- > > > From: Zurcher, Christopher J > > > Sent: Thursday, June 13, 2019 10:05 AM > > > To: devel@edk2.groups.io > > > Cc: Kinney, Michael D ; Yao, Jiewen > > ; Wang, Jian J ; Gao, > > > Liming > > > Subject: [PATCH v4 0/2] Add SCSI Support for Storage Security Command > > Protocol > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1546 > > > > > > V4 changes: > > > Add SSC Protocol in addition to BlockIo instead of in place of BlockI= o. > > > Add error handling for (BlockSize =3D=3D 0) in Read and WriteBlocks > commands > > > to handle partitions that do not support ReadCapacity(). > > > > > > V3 changes: > > > Initialize AlignedBuffer variable in ScsiDiskReceiveData and > > > ScsiDiskSendData functions. Remove redundant input validation and > debug > > > message in ScsiDiskSendData. > > > > > > V2 changes: > > > Split the patch into separate commits for separate packages. > > > > > > To support RPMB access on UFS devices, support must be added to > > > the ScsiDiskDxe driver for the Storage Security Command Protocol. > > > > > > Cc: Michael D Kinney > > > Cc: Jiewen Yao > > > Cc: Jian J Wang > > > Cc: Liming Gao > > > > > > Christopher J Zurcher (2): > > > MdePkg: Implement SCSI commands for Security Protocol In/Out > > > MdeModulePkg/ScsiDiskDxe: Support Storage Security Command > > Protocol > > > > > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- > > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 ++++++- > > > MdePkg/Include/IndustryStandard/Scsi.h | 48 +- > > > MdePkg/Include/Library/UefiScsiLib.h | 126 ++++- > > > MdePkg/Include/Protocol/ScsiIo.h | 9 +- > > > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- > > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 522 > > +++++++++++++++++++- > > > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 19 +- > > > MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 205 +++++++- > > > 9 files changed, 1064 insertions(+), 44 deletions(-) > > > > > > -- > > > 2.16.2.windows.1