From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Thu, 13 Jun 2019 18:46:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 18:46:12 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 13 Jun 2019 18:46:12 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 18:46:11 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 18:46:11 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0439.000; Fri, 14 Jun 2019 09:46:05 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , Ard Biesheuvel , "mw@semihalf.com" CC: "Albecki, Mateusz" Subject: Re: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol Thread-Topic: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol Thread-Index: AQHVGgBKjiikVvri9EawHj4okBoyTKaN38dggAtCN4CAAUs1sA== Date: Fri, 14 Jun 2019 01:46:05 +0000 Message-ID: References: <20190603113346.1288-1-mateusz.albecki@intel.com> <92CF190FF2351747A47C1708F0E09C0875E512A7@IRSMSX102.ger.corp.intel.com> In-Reply-To: <92CF190FF2351747A47C1708F0E09C0875E512A7@IRSMSX102.ger.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_B80AF82E9BFB8E4FBD8C89DA810C6A093C8F05B7SHSMSX104ccrcor_" --_000_B80AF82E9BFB8E4FBD8C89DA810C6A093C8F05B7SHSMSX104ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Loop in Ard and Marcin. Hello Ard and Marcin, We are proposing to make an extension to the SDMMC Override protocol to more customization for platforms during the SD/eMMC device/controller initialization process. For convenience, the series is available at: https://github.com/hwu25/edk2/tree/sdmmc_override_extension_v1 I only verified the change will not break the build for platforms (in edk2-platform repo). Could you help provide feedbacks for this series? Thanks in advance. Best Regards, Hao Wu From: Albecki, Mateusz Sent: Thursday, June 13, 2019 9:44 PM To: devel@edk2.groups.io Cc: Wu, Hao A Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverrid= e protocol Resending to group. From: Wu, Hao A Sent: Monday, June 10, 2019 5:18 AM To: Albecki, Mateusz Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverrid= e protocol Hello Mateusz, Thanks for the patch series and sorry for the delayed response. One question first, I did not see the patches being sent to the mailing lis= t 'devel@edk2.groups.io'. We have recently switched to this new mailing list = back to early April, the old one 'edk2-devel@lists.01.org' is no longer being us= ed. In case that you have not registered the new list, you can sign up at: https://edk2.groups.io/g/devel or email: devel+subscribe@edk2.groups.io to get registered in the new mailing list. Or you can send me the patch files and I will help to send them to the mail= ing list. Below are some general level feedbacks (Other patch-specific feedbacks will= be replied in other mails): * Could you help to add the below Bugzilla tracker reference in the= commit log message? https://bugzilla.tianocore.org/show_bug.cgi?id=3D1882 * Could you help to run the script 'BaseTools/Scripts/PatchCheck.py= ' and resolve its report on the commit log format issues? Checking git commit: 6e3f64aeb4 The commit message format is not valid: * Contributed-under! (Note: this must be removed by the code contributor!) * Add quotes (") around name with a comma: Albecki, Mateusz * Email format is invalid: hao.a.wu@intel.com * Line 15 of commit message is too long. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format The code passed all checks. Checking git commit: 91595ae911 The commit message format is not valid: * Contributed-under! (Note: this must be removed by the code contributor!) * Add quotes (") around name with a comma: Albecki, Mateusz * Email format is invalid: hao.a.wu@intel.com https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format The code passed all checks. * Could you help to resolve the typo 'Prefered' to 'Preferred' in t= he naming of some variables? * Could you help to use lowercase 'static' (instead of using the up= percase one) for the new functions? Also, I only verified the build of the patch series. Please grant me some t= ime to verify on the HW on my side. Maybe your updated patches arrive first and= I will then verify the update ones. Best Regards, Hao Wu > -----Original Message----- > From: Albecki, Mateusz > Sent: Monday, June 03, 2019 7:34 PM > Cc: Albecki, Mateusz; Wu, Hao A > Subject: [PATCH 0/2] Add GetOperatingParam notify phase to > SdMmcOverride protocol > > To allow platform greater control over the bus settings for SD card and > eMMC card > we have added a new notify phase to SdMmcOverrideProtocol called > GetOperatingParam. > This phase is signaled before SD card/eMMC initialization and allows plat= form > to tweak > the values in new structure called > EDKII_SD_MMC_OPERATING_PARAMETERS which allows to configure > bus width, clock frequency and driver strength. Other bus parameters can = be > configured by > overriding host controller capabilities. > > Tests: > - OS boot from eMMC without SdMmcOverride protocol installed > - OS boot from eMMC with SdMmcOverride installed and clock frequency > lowered to 100MHz in HS200 > - OS boot from eMMC with driver strength changed to Type1 > - SD card enumeration in UEFI shell on default speed and high speed(non > UHS-I) with SdMmcOverride installed and UHS-I disabled in capability > > > Cc: hao.a.wu@intel.com > > Albecki, Mateusz (2): > MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase > MdeModulePkg/SdMmcHcDxe: Implement revision 3 of > SdMmcOverrideProtocol > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 522 > +++++++++++++++------ > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 381 > ++++++++++++--- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 52 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 18 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 8 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 8 +- > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 58 ++- > 7 files changed, 802 insertions(+), 245 deletions(-) > > -- > 2.14.1.windows.1 --_000_B80AF82E9BFB8E4FBD8C89DA810C6A093C8F05B7SHSMSX104ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Loop in Ard and Marcin.

 

 

Hello Ard and Marcin,

 

We are proposing to make an extension to the SDMMC Override pro= tocol to

more customization for platforms during the SD/eMMC device/cont= roller

initialization process.

 

For convenience, the series is available at:<= /p>

https://github.com/hwu25/edk2/tree/sdmmc_override_ex= tension_v1

 

I only verified the change will not break the build for platfor= ms

(in edk2-platform repo). Could you help provide feedbacks for t= his series?

Thanks in advance.

 

Best Regards,

Hao Wu

 

From: Albecki, Mateusz
Sent: Thursday, June 13, 2019 9:44 PM
To: devel@edk2.groups.io
Cc: Wu, Hao A
Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol

 

Resending to group.

 

From: Wu,= Hao A
Sent: Monday, June 10, 2019 5:18 AM
To: Albecki, Mateusz <mateusz.albecki@intel.com>
Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol

 

Hello Mateusz,

 

Thanks for the patch series and sorry for the del= ayed response.

 

One question first, I did not see the patches bei= ng sent to the mailing list

'devel@edk2.groups.io'. We have recently switched= to this new mailing list back

to early April, the old one 'edk2-devel@lists.01.= org' is no longer being used.

 

In case that you have not registered the new list= , you can sign up at:

https:= //edk2.groups.io/g/devel

or email:

devel+subscribe@edk2.groups.io

to get registered in the new mailing list.

 

Or you can send me the patch files and I will hel= p to send them to the mailing list.

 

 

Below are some general level feedbacks (Other pat= ch-specific feedbacks will be replied in other mails):

·  =        Could you help to add the below Bugzilla tracker reference in the= commit log message?

https://bugzilla.tianocore.org/show_bug.cgi?id=3D1882<= o:p>

 

·  =        Could you help to run the script ‘Ba= seTools/Scripts/PatchCheck.py’ and resolve its report on the c= ommit log format issues?

Checking git com= mit: 6e3f64aeb4

The commit message format is not valid:

* Contributed-under! (Note: this must be remov= ed by the code contributor!)

* Add quotes (") around name with a comma= : Albecki, Mateusz

* Email format is invalid: hao.a.wu@intel.com

* Line 15 of commit message is too long.<= /o:p>

https://github.com/tianocore/tian= ocore.github.io/wiki/Commit-Message-Format

The code passed all checks.

 

Checking git com= mit: 91595ae911

The commit message format is not valid:

* Contributed-under! (Note: this must be remov= ed by the code contributor!)

* Add quotes (") around name with a comma= : Albecki, Mateusz

* Email format is invalid: hao.a.wu@intel.com

https://github.com/tianocore/tian= ocore.github.io/wiki/Commit-Message-Format

The code passed all checks.

 

·  =        Could you help to resolve the typo ‘= Prefered’ to ‘Preferred’ in the naming of some var= iables?

 

·  =        Could you help to use lowercase ‘static’ (instead of = using the uppercase one) for the new functions?

 

 

Also, I only verified the build of the patch seri= es. Please grant me some time

to verify on the HW on my side. Maybe your update= d patches arrive first and I

will then verify the update ones.

 

 

Best Regards,

Hao Wu

 

> -----Original Message-----

> From: Albecki, Mateusz

> Sent: Monday, June 03, 2019 7:34 PM

> Cc: Albecki, Mateusz; Wu, Hao A

> Subject: [PATCH 0/2] Add GetOperatingParam n= otify phase to

> SdMmcOverride = protocol

>

> To allow platform greater control over the b= us settings for SD card and

> eMMC card

> we have added a new notify phase to SdMmcOverrideProtocol called

> GetOperatingParam.

> This phase is signaled before SD card/eMMC i= nitialization and allows platform

> to tweak

> the values in new structure called

> EDKII_SD_MMC_OPERATING_PARAMETERS which allo= ws to configure

> bus width, clock frequency and driver streng= th. Other bus parameters can be

> configured by

> overriding host controller capabilities.

>

> Tests:

> - OS boot from eMMC without SdMmcOverride protocol installed

> - OS boot from eMMC with SdMmcOverride installed and clock frequency

> lowered to 100MHz in HS200

> - OS boot from eMMC with driver strength cha= nged to Type1

> - SD card enumeration in UEFI shell on defau= lt speed and high speed(non

> UHS-I) with SdMmcOver= ride installed and UHS-I disabled in capability

>

>

> Cc: ha= o.a.wu@intel.com

>

> Albecki, Mateusz (2):

>   MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase

>   MdeModulePkg/SdMmcHcDxe: Implement revision 3 of

> SdMmcOverrideProtocol=

>

>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c =    | 522

> +++++++++= ;++++++------

>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c &n= bsp;    | 381

> +++++++++= ;+++---

>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c |&= nbsp; 52 +-

>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h |&= nbsp; 18 +-

>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c = ;  |   8 +-

>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h = ;  |   8 +-

>  MdeModulePkg/Include/Protocol/SdMmcOverride.h      | = 58 ++-

>  7 files changed, 802 insertions(+)= , 245 deletions(-)

>

> --

> 2.14.1.windows.1

 

--_000_B80AF82E9BFB8E4FBD8C89DA810C6A093C8F05B7SHSMSX104ccrcor_--