From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=fail (domain: intel.com, ip: <nil>, mailfrom: hao.a.wu@intel.com)
Received: from mga12.intel.com (mga12.intel.com [])
 by groups.io with SMTP; Fri, 14 Jun 2019 01:43:44 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
  by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 01:43:44 -0700
X-ExtLoop1: 1
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by fmsmga001.fm.intel.com with ESMTP; 14 Jun 2019 01:43:44 -0700
Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Fri, 14 Jun 2019 01:43:43 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Fri, 14 Jun 2019 01:43:43 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000;
 Fri, 14 Jun 2019 16:43:43 +0800
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: Bret Barkelew <Bret.Barkelew@microsoft.com>, "Wang, Jian J"
	<jian.j.wang@intel.com>, "Ni, Ray" <ray.ni@intel.com>, "Zeng, Star"
	<star.zeng@intel.com>, "Gao, Liming" <liming.gao@intel.com>, Sean Brogan
	<sean.brogan@microsoft.com>, Michael Turner <Michael.Turner@microsoft.com>
Subject: Re: [PATCH 1/6] MdeModulePkg/DxeMain: Add performance code
Thread-Topic: [PATCH 1/6] MdeModulePkg/DxeMain: Add performance code
Thread-Index: AQHVH145bGtNR3zhrUO8PXOebaOeQqaayqxg
Date: Fri, 14 Jun 2019 08:43:43 +0000
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8F08E3@SHSMSX104.ccr.corp.intel.com>
References: <20190610072855.2800-1-zhichao.gao@intel.com>
 <20190610072855.2800-2-zhichao.gao@intel.com>
In-Reply-To: <20190610072855.2800-2-zhichao.gao@intel.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: hao.a.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Monday, June 10, 2019 3:29 PM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Lim=
ing;
> Sean Brogan; Michael Turner
> Subject: [PATCH 1/6] MdeModulePkg/DxeMain: Add performance code


I suggest to change the title to:
MdeModulePkg/DxeMain: Add missing PERF_FUNCTION_END for error paths

With the change,
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>=20
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1888
>=20
> Add missing PERF_FUNCTION_END before the return statement.
>=20
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c
> b/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c
> index c310b40b52..001a26aa62 100644
> --- a/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c
> +++ b/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c
> @@ -418,6 +418,7 @@ CoreDispatcher (
>      //
>      // If the dispatcher is running don't let it be restarted.
>      //
> +    PERF_FUNCTION_END ();
>      return EFI_ALREADY_STARTED;
>    }
>=20
> @@ -432,6 +433,7 @@ CoreDispatcher (
>               &DxeDispatchEvent
>               );
>    if (EFI_ERROR (Status)) {
> +    PERF_FUNCTION_END ();
>      return Status;
>    }
>=20
> --
> 2.21.0.windows.1