From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Gao, Liming" <liming.gao@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>,
"Michael Turner" <Michael.Turner@microsoft.com>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
Date: Mon, 17 Jun 2019 01:23:43 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8F0D0B@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8F026D@SHSMSX104.ccr.corp.intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Thursday, June 13, 2019 4:04 PM
> To: Gao, Zhichao; devel@edk2.groups.io
> Cc: Bret Barkelew; Gao, Liming; Sean Brogan; Michael Turner; Leif Lindholm
> Subject: Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking
> instances for build only
>
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Wednesday, June 12, 2019 10:40 AM
> > To: devel@edk2.groups.io
> > Cc: Bret Barkelew; Wu, Hao A; Gao, Liming; Sean Brogan; Michael Turner;
> Leif
> > Lindholm; Gao, Zhichao
> > Subject: [PATCH] SourceLevelDebugPkg: Add lacking instances for build
> only
>
>
> With a similar suggestion at:
> https://edk2.groups.io/g/devel/topic/32037312#42319
>
> handled:
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Pushed via commit 34857c2ff9.
Best Regards,
Hao Wu
>
> Best Regards,
> Hao Wu
>
>
> >
> > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
> >
> > Add the lacking instance to the [Components] of dsc file
> > for build only.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> > ---
> > SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > index 8be6781296..a1a1b81d03 100644
> > --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > @@ -93,6 +93,8 @@
> >
> >
> ##########################################################
> > #########################################
> >
> > [Components.common]
> > +
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> > nicationLibUsb3Dxe.inf
> > +
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> > nicationLibUsb3Pei.inf
> >
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> > mmunicationLibSerialPort.inf
> >
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommun
> > icationLibUsb.inf
> >
> >
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActio
> > nLibDebug.inf
> > --
> > 2.21.0.windows.1
>
>
>
next prev parent reply other threads:[~2019-06-17 1:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 2:39 [PATCH] CryptoPkg: Add lacking instances for build only Gao, Zhichao
2019-06-12 2:39 ` [PATCH] SourceLevelDebugPkg: " Gao, Zhichao
2019-06-13 8:03 ` Wu, Hao A
2019-06-17 1:23 ` Wu, Hao A [this message]
2019-06-12 2:39 ` [PATCH] SecurityPkg: " Gao, Zhichao
2019-06-12 2:39 ` [PATCH] MdeModulePkg: " Gao, Zhichao
2019-06-13 8:19 ` Wu, Hao A
2019-06-17 1:26 ` [edk2-devel] " Wu, Hao A
2019-06-12 8:38 ` [edk2-devel] [PATCH] CryptoPkg: " Laszlo Ersek
2019-06-13 0:32 ` Gao, Zhichao
2019-06-12 17:05 ` Wang, Jian J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C8F0D0B@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox