From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by groups.io with SMTP; Sun, 16 Jun 2019 18:23:46 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
  by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jun 2019 18:23:46 -0700
X-ExtLoop1: 1
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by fmsmga008.fm.intel.com with ESMTP; 16 Jun 2019 18:23:46 -0700
Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 16 Jun 2019 18:23:45 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 16 Jun 2019 18:23:45 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.246]) with mapi id 14.03.0439.000;
 Mon, 17 Jun 2019 09:23:43 +0800
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Wu, Hao A"
	<hao.a.wu@intel.com>, "Gao, Zhichao" <zhichao.gao@intel.com>
CC: Bret Barkelew <Bret.Barkelew@microsoft.com>, "Gao, Liming"
	<liming.gao@intel.com>, Sean Brogan <sean.brogan@microsoft.com>, "Michael
 Turner" <Michael.Turner@microsoft.com>, Leif Lindholm
	<leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
Thread-Topic: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking
 instances for build only
Thread-Index: AQHVIMgq2wsUrVFO8E2K1aT3BPTOKqaZOhsggAXa2HA=
Date: Mon, 17 Jun 2019 01:23:43 +0000
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8F0D0B@SHSMSX104.ccr.corp.intel.com>
References: <20190612023956.9180-1-zhichao.gao@intel.com>
 <20190612023956.9180-2-zhichao.gao@intel.com>
 <B80AF82E9BFB8E4FBD8C89DA810C6A093C8F026D@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8F026D@SHSMSX104.ccr.corp.intel.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: hao.a.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Thursday, June 13, 2019 4:04 PM
> To: Gao, Zhichao; devel@edk2.groups.io
> Cc: Bret Barkelew; Gao, Liming; Sean Brogan; Michael Turner; Leif Lindho=
lm
> Subject: Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking
> instances for build only
>=20
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Wednesday, June 12, 2019 10:40 AM
> > To: devel@edk2.groups.io
> > Cc: Bret Barkelew; Wu, Hao A; Gao, Liming; Sean Brogan; Michael Turner=
;
> Leif
> > Lindholm; Gao, Zhichao
> > Subject: [PATCH] SourceLevelDebugPkg: Add lacking instances for build
> only
>=20
>=20
> With a similar suggestion at:
> https://edk2.groups.io/g/devel/topic/32037312#42319
>=20
> handled:
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Pushed via commit 34857c2ff9.

Best Regards,
Hao Wu

>=20
> Best Regards,
> Hao Wu
>=20
>=20
> >
> > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1902
> >
> > Add the lacking instance to the [Components] of dsc file
> > for build only.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> > ---
> >  SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > index 8be6781296..a1a1b81d03 100644
> > --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > @@ -93,6 +93,8 @@
> >
> >
> ##########################################################
> > #########################################
> >
> >  [Components.common]
> > +
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> > nicationLibUsb3Dxe.inf
> > +
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> > nicationLibUsb3Pei.inf
> >
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> > mmunicationLibSerialPort.inf
> >
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommun
> > icationLibUsb.inf
> >
> >
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActio
> > nLibDebug.inf
> > --
> > 2.21.0.windows.1
>=20
>=20
>=20