From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Sun, 16 Jun 2019 18:26:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jun 2019 18:26:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,383,1557212400"; d="scan'208";a="185575663" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 16 Jun 2019 18:26:18 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 18:26:18 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 18:26:17 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.89]) with mapi id 14.03.0439.000; Mon, 17 Jun 2019 09:26:15 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Gao, Zhichao" CC: Bret Barkelew , "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Add lacking instances for build only Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Add lacking instances for build only Thread-Index: AQHVIMgwZOseB1dYbEewTg6hsGcPBaaZPVDAgAXYX3A= Date: Mon, 17 Jun 2019 01:26:15 +0000 Message-ID: References: <20190612023956.9180-1-zhichao.gao@intel.com> <20190612023956.9180-4-zhichao.gao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Thursday, June 13, 2019 4:20 PM > To: Gao, Zhichao; devel@edk2.groups.io > Cc: Bret Barkelew; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean = Brogan; > Michael Turner > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Add lacking instances fo= r > build only >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Wednesday, June 12, 2019 10:40 AM > > To: devel@edk2.groups.io > > Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, = Liming; > > Sean Brogan; Michael Turner > > Subject: [PATCH] MdeModulePkg: Add lacking instances for build only >=20 > There are 224 INF files in MdeModulePkg, and now there are 224 > occurrences > when searching '^ MdeModulePkg.+\.inf' in MdeModulePkg.dsc. The > number > matches. >=20 > Also, seems to me ARM & AARCH64 also build fine. >=20 > Then, with a similar suggestion at: > https://edk2.groups.io/g/devel/topic/32037312#42319 >=20 > handled: > Reviewed-by: Hao A Wu Pushed via commit 6764fb9cd8. Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > From: Bret Barkelew > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1857 > > > > Add the lacking instances to the [Components] of dsc file > > for build only. > > > > Cc: Jian J Wang > > Cc: Hao Wu > > Cc: Ray Ni > > Cc: Star Zeng > > Cc: Liming Gao > > Cc: Sean Brogan > > Cc: Michael Turner > > Cc: Bret Barkelew > > Signed-off-by: Zhichao Gao > > --- > > MdeModulePkg/MdeModulePkg.dsc | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > b/MdeModulePkg/MdeModulePkg.dsc > > index 995fd805e1..f32adc3839 100644 > > --- a/MdeModulePkg/MdeModulePkg.dsc > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > @@ -204,6 +204,22 @@ > > MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.inf > > MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf > > > > + MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > > + MdeModulePkg/Logo/Logo.inf > > + MdeModulePkg/Logo/LogoDxe.inf > > + MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > + > > > MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance > > ManagerUiLib.inf > > + MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > > + MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > > + MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf > > + MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > > + MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > > + MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.inf > > + > > > MdeModulePkg/Library/PiSmmCoreSmmServicesTableLib/PiSmmCoreSmmS > > ervicesTableLib.inf > > + MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf > > + MdeModulePkg/Library/BaseHobLibNull/BaseHobLibNull.inf > > + > > > MdeModulePkg/Library/BaseMemoryAllocationLibNull/BaseMemoryAllocati > > onLibNull.inf > > + > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > > MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf > > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > > -- > > 2.21.0.windows.1 >=20 >=20 >=20