From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by groups.io with SMTP; Mon, 17 Jun 2019 19:24:13 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 19:24:13 -0700
X-ExtLoop1: 1
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by orsmga002.jf.intel.com with ESMTP; 17 Jun 2019 19:24:11 -0700
Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 17 Jun 2019 19:24:10 -0700
Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by
 FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 17 Jun 2019 19:24:10 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by
 SHSMSX154.ccr.corp.intel.com ([169.254.7.156]) with mapi id 14.03.0439.000;
 Tue, 18 Jun 2019 10:24:08 +0800
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Ni, Ray"
	<ray.ni@intel.com>, "Javeed, Ashraf" <ashraf.javeed@intel.com>
CC: "Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
Thread-Topic: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
 every PPB device in the system
Thread-Index: AQHVFJoFZPOgonD8zEKJBHNmK8oHQqafNIqAgAGbs0A=
Date: Tue, 18 Jun 2019 02:24:08 +0000
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8F226F@SHSMSX104.ccr.corp.intel.com>
References: <20190527102356.15164-1-ashraf.javeed@intel.com>
 <734D49CCEBEEF84792F5B80ED585239D5C1D1F07@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C1D1F07@SHSMSX104.ccr.corp.intel.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: hao.a.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni=
,
> Ray
> Sent: Monday, June 17, 2019 5:49 PM
> To: Javeed, Ashraf; devel@edk2.groups.io
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion fo=
r
> every PPB device in the system
>=20
> Reviewed-by: Ray Ni <ray.ni@intel.com>

Hello all,

I did not see the origin patch being sent to the mailing list.
Maybe Ashraf has not subscribed the mailing list?

Best Regards,
Hao Wu

>=20
> > -----Original Message-----
> > From: Javeed, Ashraf
> > Sent: Monday, May 27, 2019 6:24 PM
> > To: devel@edk2.groups.io
> > Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB dev=
ice
> in
> > the system
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1796
> > Bug fixed in PciBusDxe\PciLib.c.
> > Removed the redundant second call to PciSearchDevice sub-routine when
> > the PCD for the Hot-Plug support is disabled.
> >
> > Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > ---
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> >  1 file changed, 1 insertion(+), 18 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > index f0d9f45c4a..5b55fb5d3b 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > @@ -1114,24 +1114,7 @@ PciScanBus (
> >          //
> >          // For PPB
> >          //
> > -        if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > -          //
> > -          // If Hot Plug is not supported,
> > -          // get the bridge information
> > -          //
> > -          Status =3D PciSearchDevice (
> > -                    Bridge,
> > -                    &Pci,
> > -                    StartBusNumber,
> > -                    Device,
> > -                    Func,
> > -                    &PciDevice
> > -                    );
> > -
> > -          if (EFI_ERROR (Status)) {
> > -            return Status;
> > -          }
> > -        } else {
> > +        if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> >            //
> >            // If Hot Plug is supported,
> >            // Get the bridge information
> > --
> > 2.21.0.windows.1
>=20
>=20
>=20