From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Mon, 17 Jun 2019 19:27:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 19:27:46 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 17 Jun 2019 19:27:46 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Jun 2019 19:27:45 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Jun 2019 19:27:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by shsmsx102.ccr.corp.intel.com ([169.254.2.33]) with mapi id 14.03.0439.000; Tue, 18 Jun 2019 10:27:43 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Ni, Ray" , "Javeed, Ashraf" CC: "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system Thread-Topic: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system Thread-Index: AQHVFJoFZPOgonD8zEKJBHNmK8oHQqafNIqAgAGbs0CAAADhIA== Date: Tue, 18 Jun 2019 02:27:43 +0000 Message-ID: References: <20190527102356.15164-1-ashraf.javeed@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C1D1F07@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Tuesday, June 18, 2019 10:24 AM > To: devel@edk2.groups.io; Ni, Ray; Javeed, Ashraf > Cc: Wang, Jian J > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion fo= r > every PPB device in the system >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ni, > > Ray > > Sent: Monday, June 17, 2019 5:49 PM > > To: Javeed, Ashraf; devel@edk2.groups.io > > Cc: Wang, Jian J > > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion = for > > every PPB device in the system > > > > Reviewed-by: Ray Ni >=20 > Hello all, >=20 > I did not see the origin patch being sent to the mailing list. > Maybe Ashraf has not subscribed the mailing list? Sorry, saw it at: https://edk2.groups.io/g/devel/message/41418 Acked-by: Hao A Wu Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 > > > > > -----Original Message----- > > > From: Javeed, Ashraf > > > Sent: Monday, May 27, 2019 6:24 PM > > > To: devel@edk2.groups.io > > > Cc: Javeed, Ashraf ; Wang, Jian J > > > ; Ni, Ray > > > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB > device > > in > > > the system > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1796 > > > Bug fixed in PciBusDxe\PciLib.c. > > > Removed the redundant second call to PciSearchDevice sub-routine > when > > > the PCD for the Hot-Plug support is disabled. > > > > > > Signed-off-by: Ashraf Javeed > > > Cc: Jian J Wang > > > Cc: Ray Ni > > > --- > > > MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------ > > > 1 file changed, 1 insertion(+), 18 deletions(-) > > > > > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c > > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c > > > index f0d9f45c4a..5b55fb5d3b 100644 > > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c > > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c > > > @@ -1114,24 +1114,7 @@ PciScanBus ( > > > // > > > // For PPB > > > // > > > - if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) { > > > - // > > > - // If Hot Plug is not supported, > > > - // get the bridge information > > > - // > > > - Status =3D PciSearchDevice ( > > > - Bridge, > > > - &Pci, > > > - StartBusNumber, > > > - Device, > > > - Func, > > > - &PciDevice > > > - ); > > > - > > > - if (EFI_ERROR (Status)) { > > > - return Status; > > > - } > > > - } else { > > > + if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) { > > > // > > > // If Hot Plug is supported, > > > // Get the bridge information > > > -- > > > 2.21.0.windows.1 > > > > > > >=20 >=20 >=20