From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Sun, 23 Jun 2019 18:21:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jun 2019 18:21:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,410,1557212400"; d="scan'208";a="169316994" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 23 Jun 2019 18:21:53 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 23 Jun 2019 18:21:52 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 23 Jun 2019 18:21:52 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.76]) with mapi id 14.03.0439.000; Mon, 24 Jun 2019 09:21:50 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Gao, Zhichao" CC: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew , Leif Lindholm Subject: Re: [edk2-devel] [PATCH v5 0/5] MdeModulePkg/CapsulePei: Optimize the CapsulePei Thread-Topic: [edk2-devel] [PATCH v5 0/5] MdeModulePkg/CapsulePei: Optimize the CapsulePei Thread-Index: AQHVH0xA8JFnSjY/Jk2i7u3B0/VcEKaZOjIwgBDdbhA= Date: Mon, 24 Jun 2019 01:21:49 +0000 Message-ID: References: <20190610052036.11924-1-zhichao.gao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Thursday, June 13, 2019 3:49 PM > To: Gao, Zhichao; devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael > Turner; Bret Barkelew; Leif Lindholm > Subject: Re: [edk2-devel] [PATCH v5 0/5] MdeModulePkg/CapsulePei: > Optimize the CapsulePei >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Monday, June 10, 2019 1:21 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Br= ogan; > > Michael Turner; Bret Barkelew; Leif Lindholm > > Subject: [PATCH v5 0/5] MdeModulePkg/CapsulePei: Optimize the > > CapsulePei > > > > v1: > > Sperate the capsule check function from GetCapsuleDescriptors > > and name it to AreCapsulesStaged. > > Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. > > And optimize its to remove the duplicated code. > > > > V2: > > Clarify the changes of the patch and descript in the commit > > message. > > > > V3: > > Add the code change repo location in Mu and add description of > > the changes on it. > > Do not need to remain 2 byte for the null-terminate while using > > UnicodeValueToStringS. > > > > V4: > > Separate the patch into 2 part. first part is changes from MU. > > Second part is the substantial change on it. > > > > V5: > > Separate the substantial change in 2/2 base on the purpose. >=20 >=20 > With the comment from Leif handled, for the series: > Reviewed-by: Hao A Wu Series pushed via commits ba3aa1c4e7..be5903ad1e. Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Star Zeng > > Cc: Liming Gao > > Cc: Sean Brogan > > Cc: Michael Turner > > Cc: Bret Barkelew > > Cc: Leif Lindholm > > > > Bret Barkelew (1): > > MdeModulePkg/CapsulePei: Optimize the CapsulePei > > > > Zhichao Gao (4): > > MdeMoudlePkg/CapsulePei: Fix coding style issue > > MdeMoudlePkg/CapsulePei: Optimize AreCapsulesStaged > > MdeMoudlePkg/CapsulePei: Optimize GetScatterGatherHeadEntries > > MdeMoudlePkg/CapsulePei: No need to remain space for null-terminate > > > > MdeModulePkg/Universal/CapsulePei/Capsule.h | 1 + > > .../Universal/CapsulePei/CapsulePei.inf | 1 + > > .../Universal/CapsulePei/UefiCapsule.c | 356 +++++++++--------= - > > 3 files changed, 190 insertions(+), 168 deletions(-) > > > > -- > > 2.21.0.windows.1 >=20 >=20 >=20