Re: [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules

["Wu, Hao A" <hao.a.wu@intel.com>]

Hello all,

For this RFC patch, so far it has received the below feedbacks:

* Ack tag from Laszlo:
https://edk2.groups.io/g/devel/message/42381

* Reviewed-by tag from Ray (PcAtChipsetPkg maintainer):
https://edk2.groups.io/g/devel/message/42793

* Linux Kernel soft hangs if 8259 PIC is not configured by BIOS:
https://edk2.groups.io/g/devel/topic/31823819#41532

For the last feedback, 8259 PIC can still be configured (to a reasonable
state for OS) by Chipset/SI initialization codes without requiring the
8259 driver in PcAtChipsetPkg. Hence, I think it is not considered as a
blockade for the removal of 8259 driver proposed by this patch.

If there is no other concern, I plan to push this change in 24 hours.

Best Regards,
Hao Wu


> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, May 27, 2019 2:37 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray; Andrew Fish; Laszlo Ersek; Leif Lindholm; Kinney,
> Michael D
> Subject: [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
> 
> '''
> Please note that this patch will be hold until all the below requirements
> are met:
> 
> A. edk2-stable201905 is created;
> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes
>    the IsaAcpiDxe driver);
> C. UefiPayloadPkg has been updated to drop its consume to the
>    8259InterruptControllerDxe driver.
> '''
> 
> This patch itself will not be sent to the mailing list and is only
> available at:
> https://github.com/hwu25/edk2/tree/delete_framework
> (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5
> 529e06a416)
> 
> 
> Below modules will be removed from PcAtChipsetPkg:
> * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
> 
> They are considered legacy framework components and will no longer be
> used
> after the removal of IntelFramework[Module]Pkg.
> 
> Also, the unused (after the modules being removed) PCDs will be deleted in
> package level DEC/UNI files.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> 
> Hao A Wu (1):
>   PcAtChipsetPkg: Remove framework modules
> 
>  PcAtChipsetPkg/PcAtChipsetPkg.dec                             |  58 --
>  PcAtChipsetPkg/PcAtChipsetPkg.dsc                             |   5 +-
>  PcAtChipsetPkg/8254TimerDxe/8254Timer.inf                     |  42 --
>  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf            |  46 --
>  PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf                         |  50 --
>  PcAtChipsetPkg/8254TimerDxe/Timer.h                           | 185 ------
>  PcAtChipsetPkg/8259InterruptControllerDxe/8259.h              | 220 -------
>  PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h                       | 269 ---------
>  PcAtChipsetPkg/8254TimerDxe/Timer.c                           | 401 -------------
>  PcAtChipsetPkg/8259InterruptControllerDxe/8259.c              | 622 ---------------
> -----
>  PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c                     | 301 ----------
>  PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c                           | 353 -----------
>  PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c                       | 386 ------------
>  PcAtChipsetPkg/8254TimerDxe/Timer.uni                         |  16 -
>  PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni                    |  14 -
>  PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni      |  16 -
>  PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni |  14 -
>  PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni                         |  16 -
>  PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni                    |  14 -
>  PcAtChipsetPkg/PcAtChipsetPkg.uni                             |  52 +-
>  20 files changed, 2 insertions(+), 3078 deletions(-)
>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
>  delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h
>  delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h
>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h
>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c
>  delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c
>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c
>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c
>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c
>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni
>  delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni
>  delete mode 100644
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni
>  delete mode 100644
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni
>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni
>  delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni
> 
> --
> 2.12.0.windows.1