From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Tue, 25 Jun 2019 01:06:09 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2019 01:06:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,415,1557212400"; d="scan'208";a="172274858" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 25 Jun 2019 01:06:08 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 25 Jun 2019 01:06:08 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 25 Jun 2019 01:06:07 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.246]) with mapi id 14.03.0439.000; Tue, 25 Jun 2019 16:06:05 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "'rfc@edk2.groups.io'" CC: "Ni, Ray" , Andrew Fish , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "'Kirkendall, Garrett'" Subject: Re: [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules Thread-Topic: [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules Thread-Index: AQHVFFaYjpt2evkMN0mYbjKLMEDCU6asJqPQ Date: Tue, 25 Jun 2019 08:06:05 +0000 Message-ID: References: <20190527063656.9996-1-hao.a.wu@intel.com> In-Reply-To: <20190527063656.9996-1-hao.a.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello all, For this RFC patch, so far it has received the below feedbacks: * Ack tag from Laszlo: https://edk2.groups.io/g/devel/message/42381 * Reviewed-by tag from Ray (PcAtChipsetPkg maintainer): https://edk2.groups.io/g/devel/message/42793 * Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: https://edk2.groups.io/g/devel/topic/31823819#41532 For the last feedback, 8259 PIC can still be configured (to a reasonable state for OS) by Chipset/SI initialization codes without requiring the 8259 driver in PcAtChipsetPkg. Hence, I think it is not considered as a blockade for the removal of 8259 driver proposed by this patch. If there is no other concern, I plan to push this change in 24 hours. Best Regards, Hao Wu > -----Original Message----- > From: Wu, Hao A > Sent: Monday, May 27, 2019 2:37 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Ni, Ray; Andrew Fish; Laszlo Ersek; Leif Lindholm; Kinney, > Michael D > Subject: [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules >=20 > ''' > Please note that this patch will be hold until all the below requirements > are met: >=20 > A. edk2-stable201905 is created; > B. OvmfPkg has drop its usage of the legacy ISA stack (which includes > the IsaAcpiDxe driver); > C. UefiPayloadPkg has been updated to drop its consume to the > 8259InterruptControllerDxe driver. > ''' >=20 > This patch itself will not be sent to the mailing list and is only > available at: > https://github.com/hwu25/edk2/tree/delete_framework > (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5 > 529e06a416) >=20 >=20 > Below modules will be removed from PcAtChipsetPkg: > * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf > * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf > * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf >=20 > They are considered legacy framework components and will no longer be > used > after the removal of IntelFramework[Module]Pkg. >=20 > Also, the unused (after the modules being removed) PCDs will be deleted i= n > package level DEC/UNI files. >=20 > Cc: Ray Ni > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney >=20 >=20 > Hao A Wu (1): > PcAtChipsetPkg: Remove framework modules >=20 > PcAtChipsetPkg/PcAtChipsetPkg.dec | 58 -- > PcAtChipsetPkg/PcAtChipsetPkg.dsc | 5 +- > PcAtChipsetPkg/8254TimerDxe/8254Timer.inf | 42 -- > PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf | 46 -- > PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf | 50 -- > PcAtChipsetPkg/8254TimerDxe/Timer.h | 185 ----= -- > PcAtChipsetPkg/8259InterruptControllerDxe/8259.h | 220 ----= --- > PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h | 269 ----= ----- > PcAtChipsetPkg/8254TimerDxe/Timer.c | 401 ----= --------- > PcAtChipsetPkg/8259InterruptControllerDxe/8259.c | 622 ----= ----------- > ----- > PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c | 301 ----= ------ > PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c | 353 ----= ------- > PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c | 386 ----= -------- > PcAtChipsetPkg/8254TimerDxe/Timer.uni | 16 - > PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni | 14 - > PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 - > PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 - > PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni | 16 - > PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni | 14 - > PcAtChipsetPkg/PcAtChipsetPkg.uni | 52 +- > 20 files changed, 2 insertions(+), 3078 deletions(-) > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf > delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h > delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c > delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni > delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni > delete mode 100644 > PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni > delete mode 100644 > PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni > delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni >=20 > -- > 2.12.0.windows.1