From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Tue, 25 Jun 2019 18:26:46 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2019 18:26:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,418,1557212400"; d="scan'208";a="155700149" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 25 Jun 2019 18:26:45 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 25 Jun 2019 18:26:45 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 25 Jun 2019 18:26:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.83]) with mapi id 14.03.0439.000; Wed, 26 Jun 2019 09:26:44 +0800 From: "Wu, Hao A" To: "Albecki, Mateusz" , "devel@edk2.groups.io" Subject: Re: [PATCH v3 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol Thread-Topic: [PATCH v3 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol Thread-Index: AQHVKEPLMl+YKlQELESlkF0rcl4h9aaqGvCggABmM9CAAWiSAIABP1Fw Date: Wed, 26 Jun 2019 01:26:43 +0000 Message-ID: References: <20190621151205.2444-1-mateusz.albecki@intel.com> <20190621151205.2444-3-mateusz.albecki@intel.com> <92CF190FF2351747A47C1708F0E09C0875E7341C@IRSMSX102.ger.corp.intel.com> In-Reply-To: <92CF190FF2351747A47C1708F0E09C0875E7341C@IRSMSX102.ger.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Albecki, Mateusz > Sent: Tuesday, June 25, 2019 10:14 PM > To: Wu, Hao A; devel@edk2.groups.io > Subject: RE: [PATCH v3 2/2] MdeModulePkg/SdMmcHcDxe: Implement > revision 3 of SdMmcOverrideProtocol >=20 ... >=20 > You were clear in previous mails but as I responded I am not sure if you = can > be in default 1-bit mode when the SdCardSwitch function is executed. I am > not sure if this command uses DAT lanes to transfer the data(I couldn't f= ind > information in spec) and I am unable to test it on real hardware. Could y= ou > test it on your end? If it works I see no reason not to combine those 2. >=20 I understand now. Though combining the two SdCardSwitchBusWidth() calls does work for the UHS-I card on my side, I still prefer your proposed logic with regard to performance consideration. Please help to keep this chunk of logic as is in the next series. Thanks for the explanation. Best Regards, Hao Wu