From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Mon, 01 Jul 2019 00:07:24 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 00:00:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,437,1557212400"; d="scan'208";a="362164220" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 01 Jul 2019 00:00:21 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 1 Jul 2019 00:00:21 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 1 Jul 2019 00:00:20 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 1 Jul 2019 00:00:20 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.232]) with mapi id 14.03.0439.000; Mon, 1 Jul 2019 15:00:19 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Gao, Zhichao" , "Ni, Ray" CC: "Wang, Jian J" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew Subject: Re: [edk2-devel] [PATCH v5 0/2] Use a pcd to control Platform Recovery behavior Thread-Topic: [edk2-devel] [PATCH v5 0/2] Use a pcd to control Platform Recovery behavior Thread-Index: AQHVJxqBDii3roRUV0SL0hkHW0c1h6a1ZXuw Date: Mon, 1 Jul 2019 07:00:19 +0000 Message-ID: References: <20190620034401.7932-1-zhichao.gao@intel.com> In-Reply-To: <20190620034401.7932-1-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Thursday, June 20, 2019 11:44 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brog= an; > Michael Turner; Bret Barkelew > Subject: [edk2-devel] [PATCH v5 0/2] Use a pcd to control Platform Recov= ery > behavior >=20 > V1: > Add a pcd PcdPlatformRecoverySupport to control the variable > PlatformRecovery#### and the > EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY > bit of variable "OsIndicationsSupported". >=20 > V2: > While PcdPlatformRecoverySupport is FALSE, do not set a > PlatformRecovery#### > Variable. > But remain boot from a default file path(such as \EFI\BOOT\BOOTX64.EFI). > Add memory check before build platform default boot option. >=20 > V3: > Modify the memory check operation. If fail to allocate memory for the > defualt > boot file path, put the system into dead loop to indicate it is unable t= o boot. >=20 > v4: > Add the description of PcdPlatformRecoverySupport in MdeModulePkg.uni > Fix incorrect check of LoadOption. Should check PlatformDefaultBootOptio= n. >=20 > v5: > Fix the incorrect string in MdeModulePkg.uni: > Add > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_PR > OMPT > and > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_HE > LP > base on the description in MdeModulePkg.dec file. For the series, Reviewed-by: Hao A Wu And I will take Ray's R-B tag from V4 series as well, since V5 series only addressed a typo in UNI file. Pushed via commits b7cd36a224..0889500ce1. Best Regards, Hao Wu >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew >=20 > Bret Barkelew (1): > MdeModulePkg: Add a pcd to set the OS indications bit >=20 > Zhichao Gao (1): > MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery >=20 > MdeModulePkg/MdeModulePkg.dec | 6 ++ > MdeModulePkg/MdeModulePkg.uni | 6 ++ > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 3 +- > MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 71 +++++++++++++++------ > --- > 4 files changed, 59 insertions(+), 27 deletions(-) >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20