From: "Wu, Hao A" <hao.a.wu@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rfc@edk2.groups.io" <rfc@edk2.groups.io>
Subject: Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64
Date: Wed, 3 Jul 2019 07:53:52 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C90234F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: 20190614202121.18952-3-leif.lindholm@linaro.org
> -----Original Message-----
> From: Wu, Hao A
> Sent: Wednesday, July 03, 2019 3:53 PM
> To: 'Leif Lindholm'
> Cc: devel@edk2.groups.io
> Subject: RE: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association
> for Arm/AArch64
>
> > -----Original Message-----
> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > Sent: Saturday, June 15, 2019 4:21 AM
> > To: devel@edk2.groups.io
> > Cc: Feng, Bob C; Gao, Liming; Andrew Fish; Laszlo Ersek; Kinney, Michael D;
> > Wu, Hao A
> > Subject: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for
> > Arm/AArch64
> >
> > Add Ard and Leif as responsible for any path matching
> > F: */Arm/
> > F: */AArch64/
> >
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> > Maintainers.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index cd32f9b00170..e415f51468d5 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -82,6 +82,14 @@ EDK II Releases:
> > W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-
> > Planning
> > M: Liming Gao <liming.gao@intel.com>
> >
> > +EDK II Architectures:
> > +---------------------
> > +ARM, AARCH64
> > +F: */AArch64/
> > +F: */Arm/
>
>
> Hello Leif,
>
> I want to confirm a couple of usage model for the wildcard character.
>
> Maybe they have been explained with your response to Laszlo's comments,
> but I just want to double-confirm with my using cases.
>
> 1. Matching multiple levels of directories
>
> For the below 2 folders:
> MdeModulePkg/Bus/Ufs/
> MdeModulePkg/Bus/Pci/UfsPciHcDxe/
>
> I can use:
> MdeModulePkg/*Ufs*/
>
> to match them all, right?
>
>
> 2. Matching header files (usually within the Include/ directory)
>
> In some cases, a feature may include some drivers + some include header
> files. So for the below case:
> MdeModulePkg/Include/Library/HiiLib.h
> MdeModulePkg/Include/Guid/HiiResourceSampleHii.h
> MdeModulePkg/Universal/HiiDatabaseDxe/
> MdeModulePkg/Universal/HiiResourcesSampleDxe/
> MdeModulePkg/Library/UefiHiiLib/
>
> Should I use:
> MdeModulePkg/*Hii*/
>
> to match the drivers(libraries) and the headers all or should I use:
> MdeModulePkg/*Hii*/
> MdeModulePkg/Include/*Hii*.h
>
> instead?
>
> Best Regards,
> Hao Wu
Posting to the rfc list as well.
Best Regards,
Hao Wu
>
>
> > +M: Leif Lindholm <leif.lindholm@linaro.org>
> > +M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > +
> > EDK II Packages:
> > ----------------
> > ArmPkg
> > --
> > 2.11.0
prev parent reply other threads:[~2019-07-03 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 20:21 [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64 Leif Lindholm
2019-06-20 15:29 ` [edk2-devel] " Laszlo Ersek
2019-06-20 16:07 ` Leif Lindholm
2019-07-03 7:52 ` Wu, Hao A
2019-07-03 10:44 ` Leif Lindholm
2019-07-04 6:14 ` Wu, Hao A
2019-07-04 14:27 ` Leif Lindholm
2019-07-03 7:53 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C90234F@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox