From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Wed, 03 Jul 2019 23:14:07 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 23:14:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,449,1557212400"; d="scan'208";a="247851513" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 03 Jul 2019 23:14:06 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jul 2019 23:14:06 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jul 2019 23:14:05 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by shsmsx102.ccr.corp.intel.com ([169.254.2.3]) with mapi id 14.03.0439.000; Thu, 4 Jul 2019 14:14:04 +0800 From: "Wu, Hao A" To: Leif Lindholm CC: "devel@edk2.groups.io" , "rfc@edk2.groups.io" Subject: Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64 Thread-Topic: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64 Thread-Index: AQHVIu7GtJEv32vFO0iI/51qw0Dxzaa4nYow//+u/ACAAcoFAA== Date: Thu, 4 Jul 2019 06:14:04 +0000 Message-ID: References: <20190614202121.18952-3-leif.lindholm@linaro.org> <20190703104412.yywitr2dejdwbj2m@bivouac.eciton.net> In-Reply-To: <20190703104412.yywitr2dejdwbj2m@bivouac.eciton.net> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Wednesday, July 03, 2019 6:44 PM > To: Wu, Hao A > Cc: devel@edk2.groups.io > Subject: Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path associati= on > for Arm/AArch64 >=20 > On Wed, Jul 03, 2019 at 07:52:46AM +0000, Wu, Hao A wrote: > > > -----Original Message----- > > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > > Sent: Saturday, June 15, 2019 4:21 AM > > > To: devel@edk2.groups.io > > > Cc: Feng, Bob C; Gao, Liming; Andrew Fish; Laszlo Ersek; Kinney, Mich= ael > D; > > > Wu, Hao A > > > Subject: [RFC PATCH 2/3] Maintainers.txt: add wildcard path associati= on > for > > > Arm/AArch64 > > > > > > Add Ard and Leif as responsible for any path matching > > > F: */Arm/ > > > F: */AArch64/ > > > > > > Signed-off-by: Leif Lindholm > > > --- > > > Maintainers.txt | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > > index cd32f9b00170..e415f51468d5 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -82,6 +82,14 @@ EDK II Releases: > > > W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II- > Release- > > > Planning > > > M: Liming Gao > > > > > > +EDK II Architectures: > > > +--------------------- > > > +ARM, AARCH64 > > > +F: */AArch64/ > > > +F: */Arm/ > > > > > > Hello Leif, > > > > I want to confirm a couple of usage model for the wildcard character. > > > > Maybe they have been explained with your response to Laszlo's comments, > > but I just want to double-confirm with my using cases. > > > > 1. Matching multiple levels of directories > > > > For the below 2 folders: > > MdeModulePkg/Bus/Ufs/ > > MdeModulePkg/Bus/Pci/UfsPciHcDxe/ > > > > I can use: > > MdeModulePkg/*Ufs*/ > > > > to match them all, right? >=20 > Yes, that is how it currently works (I think?). It is unclear to me if > there is consensus on how we want it to work in the future. Yes, the proposed BaseTools script is working for: MdeModulePkg/*Ufs*/ to match changes made in both directories. I am also fine (and prefer) for the wildcard character to match multiple levels of folders. >=20 > > 2. Matching header files (usually within the Include/ directory) > > > > In some cases, a feature may include some drivers + some include header > > files. So for the below case: > > MdeModulePkg/Include/Library/HiiLib.h > > MdeModulePkg/Include/Guid/HiiResourceSampleHii.h > > MdeModulePkg/Universal/HiiDatabaseDxe/ > > MdeModulePkg/Universal/HiiResourcesSampleDxe/ > > MdeModulePkg/Library/UefiHiiLib/ > > > > Should I use: > > MdeModulePkg/*Hii*/ > > > > to match the drivers(libraries) and the headers all or should I use: > > MdeModulePkg/*Hii*/ > > MdeModulePkg/Include/*Hii*.h >=20 > My view is that this second option would be required. > If MdeModulePkg/*Hii*/ matches on the .h files, that is effectively a > bug - is that the behaviour you are currently seeing? The script is working like the 2nd option, and I think it is expected. So, there seems to me no bug in my tests. I do met a little problem that for a patch that touches multiple features, the contacts order in the output is not ideally perfect: Content in Maintainers.txt: ''' MdeModulePkg F: MdeModulePkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg M: Jian J Wang M: Hao A Wu F: MdeModulePkg/*Ufs*/ R: Ufs Guy F: MdeModulePkg/Include/*Hii*.h F: MdeModulePkg/*Hii*/ R: Hii Guy ''' Script output: ''' $ py BaseTools/Scripts/GetMaintainer.py HEAD MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.uni Jian J Wang Hao A Wu Ufs Guy devel@edk2.groups.io Hii Guy ''' The 'Hii Guy' is at the end of the list. But this is a rather minor problem and does not impact the use at all. Best Regards, Hao Wu >=20 > Best Regards, >=20 > Leif