From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/2] Remove S3Lib and RecoveryLib
Date: Mon, 5 Aug 2019 02:13:32 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C915321@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190802065527.17208-1-shenglei.zhang@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Friday, August 02, 2019 2:55 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [edk2-devel] [PATCH 0/2] Remove S3Lib and RecoveryLib
>
> S3Lib and RecoveryLib have been deprecated since 2009.
> There is no code using AcpiS3ResumeOs() interface in S3Lib and
> PeiRecoverFirmware() interface in RecoveryLib.
> So they can be removed from edk2 repo.
For the series:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
And pushed via commits 1702e2ce5a..4ac8ceb5d6.
Best Regards,
Hao Wu
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Shenglei Zhang (2):
> MdeModulePkg: Remove S3Lib.h and PeiS3LibNull
> MdeModulePkg: Remove RecoveryLib.h and PeiRecoveryLibNull
>
> .../PeiRecoveryLibNull/PeiRecoveryLibNull.c | 28 ---------------
> .../Library/PeiS3LibNull/PeiS3LibNull.c | 29 ----------------
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 2 --
> MdeModulePkg/Include/Library/RecoveryLib.h | 29 ----------------
> MdeModulePkg/Include/Library/S3Lib.h | 28 ---------------
> .../PeiRecoveryLibNull/PeiRecoveryLibNull.inf | 33 ------------------
> .../PeiRecoveryLibNull/PeiRecoveryLibNull.uni | 18 ----------
> .../Library/PeiS3LibNull/PeiS3LibNull.inf | 34 -------------------
> .../Library/PeiS3LibNull/PeiS3LibNull.uni | 18 ----------
> MdeModulePkg/MdeModulePkg.dec | 10 ------
> MdeModulePkg/MdeModulePkg.dsc | 2 --
> 11 files changed, 231 deletions(-)
> delete mode 100644
> MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.c
> delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.c
> delete mode 100644 MdeModulePkg/Include/Library/RecoveryLib.h
> delete mode 100644 MdeModulePkg/Include/Library/S3Lib.h
> delete mode 100644
> MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.inf
> delete mode 100644
> MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.uni
> delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.inf
> delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.uni
>
> --
> 2.18.0.windows.1
>
>
>
prev parent reply other threads:[~2019-08-05 2:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 6:55 [PATCH 0/2] Remove S3Lib and RecoveryLib Zhang, Shenglei
2019-08-02 6:55 ` [PATCH 1/2] MdeModulePkg: Remove S3Lib.h and PeiS3LibNull Zhang, Shenglei
2019-08-02 15:13 ` [edk2-devel] " Ni, Ray
2019-08-02 6:55 ` [PATCH 2/2] MdeModulePkg: Remove RecoveryLib.h and PeiRecoveryLibNull Zhang, Shenglei
2019-08-02 15:13 ` Ni, Ray
2019-08-05 2:13 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C915321@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox