From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Sun, 04 Aug 2019 19:13:40 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2019 19:13:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,348,1559545200"; d="scan'208";a="181550108" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 04 Aug 2019 19:13:35 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 4 Aug 2019 19:13:34 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 4 Aug 2019 19:13:35 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Mon, 5 Aug 2019 10:13:33 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Zhang, Shenglei" CC: "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH 0/2] Remove S3Lib and RecoveryLib Thread-Topic: [edk2-devel] [PATCH 0/2] Remove S3Lib and RecoveryLib Thread-Index: AQHVSP9Qr1Tf+jFptUmlGv05fJhTU6br1ADQ Date: Mon, 5 Aug 2019 02:13:32 +0000 Message-ID: References: <20190802065527.17208-1-shenglei.zhang@intel.com> In-Reply-To: <20190802065527.17208-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Friday, August 02, 2019 2:55 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [edk2-devel] [PATCH 0/2] Remove S3Lib and RecoveryLib >=20 > S3Lib and RecoveryLib have been deprecated since 2009. > There is no code using AcpiS3ResumeOs() interface in S3Lib and > PeiRecoverFirmware() interface in RecoveryLib. > So they can be removed from edk2 repo. For the series: Reviewed-by: Hao A Wu And pushed via commits 1702e2ce5a..4ac8ceb5d6. Best Regards, Hao Wu >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Shenglei Zhang (2): > MdeModulePkg: Remove S3Lib.h and PeiS3LibNull > MdeModulePkg: Remove RecoveryLib.h and PeiRecoveryLibNull >=20 > .../PeiRecoveryLibNull/PeiRecoveryLibNull.c | 28 --------------- > .../Library/PeiS3LibNull/PeiS3LibNull.c | 29 ---------------- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 2 -- > MdeModulePkg/Include/Library/RecoveryLib.h | 29 ---------------- > MdeModulePkg/Include/Library/S3Lib.h | 28 --------------- > .../PeiRecoveryLibNull/PeiRecoveryLibNull.inf | 33 ------------------ > .../PeiRecoveryLibNull/PeiRecoveryLibNull.uni | 18 ---------- > .../Library/PeiS3LibNull/PeiS3LibNull.inf | 34 ------------------- > .../Library/PeiS3LibNull/PeiS3LibNull.uni | 18 ---------- > MdeModulePkg/MdeModulePkg.dec | 10 ------ > MdeModulePkg/MdeModulePkg.dsc | 2 -- > 11 files changed, 231 deletions(-) > delete mode 100644 > MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.c > delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.c > delete mode 100644 MdeModulePkg/Include/Library/RecoveryLib.h > delete mode 100644 MdeModulePkg/Include/Library/S3Lib.h > delete mode 100644 > MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.inf > delete mode 100644 > MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.uni > delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.inf > delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.uni >=20 > -- > 2.18.0.windows.1 >=20 >=20 >=20