public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Jin, Eric" <eric.jin@intel.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"afish@apple.com" <afish@apple.com>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers
Date: Mon, 5 Aug 2019 06:19:42 +0000	[thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C916497@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190731145903.13820-1-eric.jin@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Eric Jin
> Sent: Wednesday, July 31, 2019 10:59 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple
> controllers
> 
> Multiple Controllers Support solution
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525
> 
> The patch set is to makes enhancement to the ESRT when multiple
> same controllers exist in one system.
> 
> Eric Jin (3):
>   MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT
>   MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT
>   MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance


Hello Eric,

After looking into the series, I found that patches 2/3 & 3/3 are actually
addressing issues introduced by the 1/3 patch. It looks to me that these
3 patches should be squashed into 1 commit, since they all focus on adding
a feature for ESRT to support multiple controllers.

However, originally, the 3 separate commits come from the edk2-staging
repository, so I am not very sure what approach should be adopted when
merging them back to the edk2 repo master branch.

(Includes the stewards here for suggestions.)

My personal preference is to merge them together as one patch.

Best Regards,
Hao Wu


> 
>  MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 394 +++++++++++++---
> ----
>  1 file changed, 257 insertions(+), 137 deletions(-)
> 
> --
> 2.20.1.windows.1
> 
> 
> 


  parent reply	other threads:[~2019-08-05  6:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 14:59 [PATCH 0/3] Enhance ESRT to support multiple controllers Eric Jin
2019-07-31 21:03 ` [edk2-devel] " Laszlo Ersek
2019-08-05  8:09   ` Eric Jin
2019-08-05  6:19 ` Wu, Hao A [this message]
2019-08-05  8:15   ` Eric Jin
2019-08-07 12:39   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C916497@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox