From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: hao.a.wu@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Sun, 04 Aug 2019 23:19:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2019 23:19:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,348,1559545200"; d="scan'208";a="373604623" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 04 Aug 2019 23:19:45 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 4 Aug 2019 23:19:44 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 4 Aug 2019 23:19:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Mon, 5 Aug 2019 14:19:43 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Jin, Eric" CC: "Gao, Liming" , "Kinney, Michael D" , "afish@apple.com" , "lersek@redhat.com" , "leif.lindholm@linaro.org" Subject: Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers Thread-Topic: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers Thread-Index: AQHVR7CcmmluSTdBu0GC9OJSpAk4lKbsFlsw Date: Mon, 5 Aug 2019 06:19:42 +0000 Message-ID: References: <20190731145903.13820-1-eric.jin@intel.com> In-Reply-To: <20190731145903.13820-1-eric.jin@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Eric Jin > Sent: Wednesday, July 31, 2019 10:59 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple > controllers >=20 > Multiple Controllers Support solution >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1525 >=20 > The patch set is to makes enhancement to the ESRT when multiple > same controllers exist in one system. >=20 > Eric Jin (3): > MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT > MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT > MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance Hello Eric, After looking into the series, I found that patches 2/3 & 3/3 are actually addressing issues introduced by the 1/3 patch. It looks to me that these 3 patches should be squashed into 1 commit, since they all focus on adding a feature for ESRT to support multiple controllers. However, originally, the 3 separate commits come from the edk2-staging repository, so I am not very sure what approach should be adopted when merging them back to the edk2 repo master branch. (Includes the stewards here for suggestions.) My personal preference is to merge them together as one patch. Best Regards, Hao Wu >=20 > MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 394 +++++++++++++--- > ---- > 1 file changed, 257 insertions(+), 137 deletions(-) >=20 > -- > 2.20.1.windows.1 >=20 >=20 >=20