From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 07 Aug 2019 01:15:28 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 01:15:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,356,1559545200"; d="scan'208";a="179409846" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga006.jf.intel.com with ESMTP; 07 Aug 2019 01:15:27 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 01:15:27 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 01:15:26 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Wed, 7 Aug 2019 16:15:25 +0800 From: "Wu, Hao A" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Justen, Jordan L" , Andrew Fish , "Ni, Ray" Subject: Re: [edk2-devel] [Patch 1/3] EmulatorPkg: Fix VS20xx IA32 boot failure Thread-Topic: [edk2-devel] [Patch 1/3] EmulatorPkg: Fix VS20xx IA32 boot failure Thread-Index: AQHVTNd+Rm75Bk+rO0iAi4yFu3ogK6bvMWIg//+WOgCAAIxIkA== Date: Wed, 7 Aug 2019 08:15:24 +0000 Message-ID: References: <20190807042028.21988-1-michael.d.kinney@intel.com> <20190807042028.21988-2-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, August 07, 2019 3:43 PM > To: Wu, Hao A; devel@edk2.groups.io; Kinney, Michael D > Cc: Justen, Jordan L; Andrew Fish; Ni, Ray > Subject: RE: [edk2-devel] [Patch 1/3] EmulatorPkg: Fix VS20xx IA32 boot > failure >=20 > I observed 2 failure modes >=20 > 1) The range could not be mapped at the request address > And an error message was displayed and the app exited. > 2) The mapping passed, but when it was accessed by the > Sec module, the app generated an exception. Thanks for the additional information. For case 2), even though it might not be directly related with this issue. I think it would be the best to ensure WinNtOpenFile() returns with success only when the map operation takes effect. For this patch: Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > Mike >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Tuesday, August 6, 2019 11:19 PM > > To: devel@edk2.groups.io; Kinney, Michael D > > > > Cc: Justen, Jordan L ; > > Andrew Fish ; Ni, Ray > > > > Subject: RE: [edk2-devel] [Patch 1/3] EmulatorPkg: Fix > > VS20xx IA32 boot failure > > > > > -----Original Message----- > > > From: devel@edk2.groups.io > > [mailto:devel@edk2.groups.io] On Behalf Of > > > Michael D Kinney > > > Sent: Wednesday, August 07, 2019 12:20 PM > > > To: devel@edk2.groups.io > > > Cc: Justen, Jordan L; Andrew Fish; Ni, Ray > > > Subject: [edk2-devel] [Patch 1/3] EmulatorPkg: Fix > > VS20xx IA32 boot > > > failure > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2056 > > > > > > The IA32 build of the EmulatorPkg for VS20xx does not > > boot because the > > > default value of PCD PcdPeiServicesTablePage is set > > for X64 Windows > > > Host environments. If the EmulatorPkg is build for > > an IA32 Windows > > > Host environment, then set this PCD to 0x13000000 > > that can be mapped > > > into a 32-bit user process. > > > > > > Hello Mike, > > > > I have a question for this patch. > > > > For the main() function within file > > EmulatorPkg/Win/Host/WinHost.c, I saw the below codes: > > > > EmuMagicPage =3D (VOID *)(UINTN)(FixedPcdGet64 > > (PcdPeiServicesTablePage) & MAX_UINTN); > > if (EmuMagicPage !=3D NULL) { > > UINT64 Size; > > Status =3D WinNtOpenFile ( > > NULL, > > SIZE_4KB, > > 0, > > &EmuMagicPage, > > &Size > > ); > > if (EFI_ERROR (Status)) { > > SecPrint ("ERROR : Could not allocate > > PeiServicesTablePage @ %p\n", EmuMagicPage); > > return EFI_DEVICE_ERROR; > > } > > } > > > > My understanding is that the WinNtOpenFile() function > > call is attempting to map the address specified by > > 'EmuMagicPage'. For IA32 case, the value in > > 'EmuMagicPage' here has already been truncated > > (0x03000000). If the > > WinNtOpenFile() call returned successfully, the address > > should be mapped. > > > > Is it the case that even if WinNtOpenFile() returns > > with no error, the specified address (0x03000000) is > > not actually being mapped? > > > > Best Regards, > > Hao Wu > > > > > > > > > > Cc: Jordan Justen > > > Cc: Andrew Fish > > > Cc: Ray Ni > > > Signed-off-by: Michael D Kinney > > > > > --- > > > EmulatorPkg/EmulatorPkg.dsc | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/EmulatorPkg/EmulatorPkg.dsc > > b/EmulatorPkg/EmulatorPkg.dsc > > > index ea8b6ce76e..c4ec10d1d8 100644 > > > --- a/EmulatorPkg/EmulatorPkg.dsc > > > +++ b/EmulatorPkg/EmulatorPkg.dsc > > > @@ -4,7 +4,7 @@ > > > # The Emulation Platform can be used to debug > > individual modules, > > > prior to creating # a real platform. This also > > provides an example > > > for how an DSC is created. > > > # > > > -# Copyright (c) 2006 - 2018, Intel Corporation. All > > rights > > > reserved.
> > > +# Copyright (c) 2006 - 2019, Intel Corporation. All > > rights > > > +reserved.
> > > # Portions copyright (c) 2010 - 2011, Apple Inc. All > > rights > > > reserved.
# # SPDX-License-Identifier: BSD-2- > > Clause-Patent @@ > > > -225,6 +225,10 @@ [PcdsFixedAtBuild] > > > # 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM > > > gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1 > > > > > > +!if "IA32" in $(ARCH) && "MSFT" in $(FAMILY) > > > + > > gEmulatorPkgTokenSpaceGuid.PcdPeiServicesTablePage|0x13 > > 000000 > > > +!endif > > > + > > > [PcdsDynamicDefault.common.DEFAULT] > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpar > > eBase64|0 > > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWork > > ingBase64| > > > 0 > > > -- > > > 2.21.0.windows.1 > > > > > > > > >=20