From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Wed, 07 Aug 2019 01:24:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 01:24:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,356,1559545200"; d="scan'208";a="373691975" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 07 Aug 2019 01:24:53 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 01:24:54 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 01:24:53 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Wed, 7 Aug 2019 16:24:51 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add missing description for parameter Thread-Topic: [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add missing description for parameter Thread-Index: AQHVS/0ibOalpGPGdUWD8IemNLUPXKbtuPmw Date: Wed, 7 Aug 2019 08:24:51 +0000 Message-ID: References: <20190806021737.17672-1-shenglei.zhang@intel.com> In-Reply-To: <20190806021737.17672-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, August 06, 2019 10:18 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add missing > description for parameter >=20 > The description of parameter CapFileName is missing in comments. > So add the description. >=20 > Cc: Jian J Wang > Cc: Hao A Wu Hello, One comment that is not related with the patch itself. In the future, please help to run the 'GetMaintainer.py' script under BaseTools/Scripts/ to get the CC list when proposing a patch in the MdeModulePkg. For the patch: Reviewed-by: Hao A Wu And the pushed via commit 111bbcf876. Best Regards, Hao Wu > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git > a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c > b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c > index 2cecc87385b3..f2cd0ad3e816 100644 > --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c > +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c > @@ -136,6 +136,7 @@ UINT32 mCapsuleTotalNumber; > Caution: This function may receive untrusted input. >=20 > @param[in] CapsuleHeader Points to a capsule header. > + @param[in] CapFileName Capsule file name. > @param[out] ResetRequired Indicates whether reset is required = or not. >=20 > @retval EFI_SUCESS Process Capsule Image successfully. > -- > 2.18.0.windows.1