From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 07 Aug 2019 22:54:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 22:54:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,360,1559545200"; d="scan'208";a="350064744" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 07 Aug 2019 22:54:46 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 22:54:45 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 22:54:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.65]) with mapi id 14.03.0439.000; Thu, 8 Aug 2019 13:54:43 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Justen, Jordan L" , Andrew Fish , "Ni, Ray" Subject: Re: [edk2-devel] [Patch V2 1/3] EmulatorPkg: Fix VS20xx IA32 boot failure Thread-Topic: [edk2-devel] [Patch V2 1/3] EmulatorPkg: Fix VS20xx IA32 boot failure Thread-Index: AQHVTZCiOJ3rc201PUaHzj2zbnr4+KbwwDww Date: Thu, 8 Aug 2019 05:54:43 +0000 Message-ID: References: <20190808022556.18828-1-michael.d.kinney@intel.com> <20190808022556.18828-2-michael.d.kinney@intel.com> In-Reply-To: <20190808022556.18828-2-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Thursday, August 08, 2019 10:26 AM > To: devel@edk2.groups.io > Cc: Justen, Jordan L; Andrew Fish; Ni, Ray > Subject: [edk2-devel] [Patch V2 1/3] EmulatorPkg: Fix VS20xx IA32 boot > failure >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2056 >=20 > The IA32 build of the EmulatorPkg for VS20xx does not boot > because the default value of PCD PcdPeiServicesTablePage > rarely succeeds to be mapped on IA32 Windows Host Environments. > Change the DEC default value for this PCD to a value that > is compatible with Windows and POSIX host environments for > IA32 and X64. For IA32 builds, this 64-bit PCD is truncated > to a 32-bit value. >=20 > PcdPeiServicesTablePage is changed from 0x1003000000 to > 0x1013000000. With this new value, no boot failures are > observed. However, the use of this hard coded value can > potentially cause a boot failure if this address specified > by the PCD is already allocated in the user process. Thanks for the additional information, the patch is good to me, Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > Cc: Jordan Justen > Cc: Andrew Fish > Cc: Ray Ni > Signed-off-by: Michael D Kinney > --- > EmulatorPkg/EmulatorPkg.dec | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec > index c36f2c4186..99250d9fe5 100644 > --- a/EmulatorPkg/EmulatorPkg.dec > +++ b/EmulatorPkg/EmulatorPkg.dec > @@ -2,7 +2,7 @@ > # > # This is the Emu Emulation Environment Platform > # > -# Copyright (c) 2008 - 2011, Intel Corporation. All rights reserved. > +# Copyright (c) 2008 - 2019, Intel Corporation. All rights reserved. > # Portions copyright (c) 2011, Apple Inc. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -66,7 +66,7 @@ [PcdsFixedAtBuild] > gEmulatorPkgTokenSpaceGuid.PcdEmuApCount|L"0"|VOID*|0x00001019 >=20 > ## Magic page to implement PEI Services Table Pointer Lib > - > gEmulatorPkgTokenSpaceGuid.PcdPeiServicesTablePage|0x1003000000|UIN > T64|0x0000101b > + > gEmulatorPkgTokenSpaceGuid.PcdPeiServicesTablePage|0x1013000000|UIN > T64|0x0000101b >=20 > ## Size of the packet filter >=20 > gEmulatorPkgTokenSpaceGuid.PcdNetworkPacketFilterSize|524288|UINT32 > |0x0000101c > -- > 2.21.0.windows.1 >=20 >=20 >=20