From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Sun, 11 Aug 2019 18:59:49 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 18:59:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,375,1559545200"; d="scan'208";a="177347003" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 11 Aug 2019 18:59:48 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 18:59:48 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 18:59:48 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 09:59:46 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Zhang, Shenglei" CC: "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files in INF files Thread-Topic: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files in INF files Thread-Index: AQHVTbILNXU23Pven0Gw+dzmmkwBF6b2xWNg Date: Mon, 12 Aug 2019 01:59:45 +0000 Message-ID: References: <20190808062456.6116-1-shenglei.zhang@intel.com> <20190808062456.6116-2-shenglei.zhang@intel.com> In-Reply-To: <20190808062456.6116-2-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Thursday, August 08, 2019 2:25 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Gao, Liming > Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files > in INF files >=20 > The header files are used but missing in INF,which causes > generating warning message when building them. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 1 + > MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 7 +++++++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > index 786c41163304..adf9f1502d69 100644 > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > @@ -33,6 +33,7 @@ [Sources] > UefiCapsule.c > Capsule.h > Common/CapsuleCoalesce.c > + Common/CommonHeader.h File 'Common/CapsuleCoalesce.c' is referring the header 'Common/CommonHeader.h'. The patch updates CapsulePei.inf, but there is a similar case in CapsuleX64.inf as well. Could you help to check whether such change is needed there? >=20 > [Packages] > MdePkg/MdePkg.dec > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > index af002bd98e99..2a4e256063a6 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > @@ -28,6 +28,13 @@ [Sources] > EbcDebugger/EdbCommon.h > EbcDebugger/EdbSupportString.c > EbcDebugger/EdbSupport.h > + EbcDebugger/EdbCommand.h > + EbcDebugger/EdbHook.h > + EbcDebugger/Edb.h > + EbcDebugger/EdbDisasmSupport.h > + EbcDebugger/EdbDisasm.h > + EbcDebugger/EdbSymbol.h > + EbcDebuggerHook.h Could you help to check whether the below 3 INF files within MdeModulePkg/Universal/EbcDxe have listed all used files in them? (At least, I think there might be something missing in EbcDxe.inf) Best Regards, Hao Wu >=20 > [Packages] > MdePkg/MdePkg.dec > -- > 2.18.0.windows.1 >=20 >=20 >=20