public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
	Andrew Fish <afish@apple.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [Patch V3 4/4] EmulatorPkg: Add support for NOOPT target
Date: Mon, 12 Aug 2019 02:30:40 +0000	[thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9186C6@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190809224405.13536-5-michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Saturday, August 10, 2019 6:44 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L; Andrew Fish; Ni, Ray
> Subject: [edk2-devel] [Patch V3 4/4] EmulatorPkg: Add support for NOOPT
> target
> 
> Add NOOPT to BUILD_TARGETS in DSC file.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  EmulatorPkg/EmulatorPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
> index 529adfe1fa..0af2d1ff95 100644
> --- a/EmulatorPkg/EmulatorPkg.dsc
> +++ b/EmulatorPkg/EmulatorPkg.dsc
> @@ -19,7 +19,7 @@ [Defines]
>    OUTPUT_DIRECTORY               = Build/Emulator$(ARCH)
> 
>    SUPPORTED_ARCHITECTURES        = X64|IA32
> -  BUILD_TARGETS                  = DEBUG|RELEASE
> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>    SKUID_IDENTIFIER               = DEFAULT
>    FLASH_DEFINITION               = EmulatorPkg/EmulatorPkg.fdf
> 
> --
> 2.21.0.windows.1
> 
> 
> 


  reply	other threads:[~2019-08-12  2:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 22:44 [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config Michael D Kinney
2019-08-09 22:44 ` [Patch V3 1/4] EmulatorPkg: Fix VS20xx IA32 boot failure Michael D Kinney
2019-08-09 22:44 ` [Patch V3 2/4] EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD Michael D Kinney
2019-08-09 22:44 ` [Patch V3 3/4] EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES Michael D Kinney
2019-08-09 22:44 ` [Patch V3 4/4] EmulatorPkg: Add support for NOOPT target Michael D Kinney
2019-08-12  2:30   ` Wu, Hao A [this message]
2019-08-09 23:08 ` [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config Jordan Justen
2019-08-10  4:46   ` [edk2-devel] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C9186C6@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox