From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: hao.a.wu@intel.com)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by groups.io with SMTP; Sun, 11 Aug 2019 19:30:43 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
  by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 19:30:42 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,375,1559545200"; 
   d="scan'208";a="177351701"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
  by fmsmga007.fm.intel.com with ESMTP; 11 Aug 2019 19:30:42 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 11 Aug 2019 19:30:42 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000;
 Mon, 12 Aug 2019 10:30:40 +0800
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Kinney, Michael D"
	<michael.d.kinney@intel.com>
CC: "Justen, Jordan L" <jordan.l.justen@intel.com>, Andrew Fish
	<afish@apple.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [Patch V3 4/4] EmulatorPkg: Add support for NOOPT target
Thread-Topic: [edk2-devel] [Patch V3 4/4] EmulatorPkg: Add support for NOOPT
 target
Thread-Index: AQHVTwQBDTPA3a2/jESlReStIrwWjKb2zbxg
Date: Mon, 12 Aug 2019 02:30:40 +0000
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9186C6@SHSMSX104.ccr.corp.intel.com>
References: <20190809224405.13536-1-michael.d.kinney@intel.com>
 <20190809224405.13536-5-michael.d.kinney@intel.com>
In-Reply-To: <20190809224405.13536-5-michael.d.kinney@intel.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: hao.a.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Saturday, August 10, 2019 6:44 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L; Andrew Fish; Ni, Ray
> Subject: [edk2-devel] [Patch V3 4/4] EmulatorPkg: Add support for NOOPT
> target
>=20
> Add NOOPT to BUILD_TARGETS in DSC file.
>=20
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  EmulatorPkg/EmulatorPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
> index 529adfe1fa..0af2d1ff95 100644
> --- a/EmulatorPkg/EmulatorPkg.dsc
> +++ b/EmulatorPkg/EmulatorPkg.dsc
> @@ -19,7 +19,7 @@ [Defines]
>    OUTPUT_DIRECTORY               =3D Build/Emulator$(ARCH)
>=20
>    SUPPORTED_ARCHITECTURES        =3D X64|IA32
> -  BUILD_TARGETS                  =3D DEBUG|RELEASE
> +  BUILD_TARGETS                  =3D DEBUG|RELEASE|NOOPT


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>    SKUID_IDENTIFIER               =3D DEFAULT
>    FLASH_DEFINITION               =3D EmulatorPkg/EmulatorPkg.fdf
>=20
> --
> 2.21.0.windows.1
>=20
>=20
>=20