From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: hao.a.wu@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Sun, 11 Aug 2019 19:38:56 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 19:38:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,375,1559545200"; d="scan'208";a="177352975" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 11 Aug 2019 19:38:55 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 19:38:55 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 19:38:55 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 10:38:53 +0800 From: "Wu, Hao A" To: "Albecki, Mateusz" , "devel@edk2.groups.io" CC: Andrew Fish , Laszlo Ersek , "Leif Lindholm" , "Kinney, Michael D" , "Gao, Liming" Subject: Re: [PATCHv3 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers Thread-Topic: [PATCHv3 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers Thread-Index: AQHVTr/YjJr39dyuWUOQRjc8fwAf0qb2vmWA Date: Mon, 12 Aug 2019 02:38:52 +0000 Message-ID: References: <20190809143620.4924-1-mateusz.albecki@intel.com> In-Reply-To: <20190809143620.4924-1-mateusz.albecki@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Albecki, Mateusz > Sent: Friday, August 09, 2019 10:36 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A > Subject: [PATCHv3 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to > support platform specific programming of UFS host controllers >=20 > To cover additional host controller programming mentioned in the UFS > specification we have added an additional protocol that allows the UEFI > driver to give control to platform driver. This allows the platform to pe= rform > any additional steps needed for the stable operation. >=20 > Changes in v3: > - UFS driver will abort initializaton when it fails to get host controler > information > - Fixed bug with calling post link startup callback on failed device dete= ction >=20 > Test coverage: > Tested on platform with UFS 2.1 host controller with Samsung UFS2.0 part > with 3 LUs enabled All LUs have been enumerated in boot manager. > Tested that enumeration works without platform protocol installed(on host > controller that can support it) Tested that enumeration works with platfo= rm > protocol installed and with additional programming steps after link > startup(power mode change to GEAR2). >=20 > Cc: Hao A Wu =20 >=20 > Mateusz Albecki (4): > MdeModulePkg: Add definition of the > EDKII_UFS_HC_PLATFORM_PROTOCOL > MdeModulePkg/UfsPassThruDxe: Refactor UfsExecUicCommand function > MdeModulePkg/UfsPassThruDxe: Refactor private data to use > EDKII_UFS_HC_INFO > MdeModulePkg/UfsPassThruDxe: Implement > EDKII_UFS_HC_PLATFORM_PROTOCOL For the 3rd patch, in order to please the PatchCheck.py, I will change the title a little bit to: * MdeModulePkg/UfsPassThruDxe: Refactor private data to use UfsHcInfo Other than that, for the series, Reviewed-by: Hao A Wu Since there is already a confirmation from Laszlo for adding this feature i= n the upcoming stable tag: https://edk2.groups.io/g/devel/message/45217?p=3D,,,20,0,0,0::Created,,ufs,= 20,2,0,32784353 I plan to push the series tomorrow (after around 24 hours, in case if there are additional feedbacks). Best Regards, Hao Wu >=20 > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 26 +++- > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 44 +++++- > .../Bus/Ufs/UfsPassThruDxe/UfsPassThruDxe.inf | 3 +- > .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 173 +++++++++++++++= - > ----- > .../Include/Protocol/UfsHostControllerPlatform.h | 124 +++++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 3 + > 6 files changed, 324 insertions(+), 49 deletions(-) > create mode 100644 > MdeModulePkg/Include/Protocol/UfsHostControllerPlatform.h >=20 > -- > 2.14.1.windows.1