From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Sun, 11 Aug 2019 23:56:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 23:56:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,376,1559545200"; d="scan'208";a="178249127" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 11 Aug 2019 23:56:19 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 23:56:19 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 11 Aug 2019 23:56:19 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 11 Aug 2019 23:56:18 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 14:56:17 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files Thread-Topic: [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF files Thread-Index: AQHVUNZe30n0pSRJWUmVrjR68R+2Aqb3FEYg Date: Mon, 12 Aug 2019 06:56:16 +0000 Message-ID: References: <20190812062243.14472-1-shenglei.zhang@intel.com> <20190812062243.14472-2-shenglei.zhang@intel.com> In-Reply-To: <20190812062243.14472-2-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 2:23 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [PATCH v2 1/3] MdeModulePkg: Add missing header files in INF fil= es >=20 > The header files are used but missing in INF,which causes > generating warning message when building them. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Shenglei Zhang > --- > v2: Add "Common/CommonHeader.h" in CapsuleX64.inf. > MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 ++- > MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf | 1 + > MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 9 ++++++++- > 3 files changed, 11 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > index 786c41163304..e5078c79863c 100644 > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > @@ -6,7 +6,7 @@ > # This external input must be validated carefully to avoid security iss= ue like > # buffer overflow, integer overflow. > # > -# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> # Copyright (c) 2017, AMD Incorporated. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -33,6 +33,7 @@ [Sources] > UefiCapsule.c > Capsule.h > Common/CapsuleCoalesce.c > + Common/CommonHeader.h >=20 > [Packages] > MdePkg/MdePkg.dec > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf > b/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf > index 95e5f68c9892..35d2535a5b48 100644 > --- a/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf > +++ b/MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf > @@ -33,6 +33,7 @@ [Sources] > X64/X64Entry.c > X64/PageFaultHandler.nasm > Common/CapsuleCoalesce.c > + Common/CommonHeader.h >=20 > [Packages] > MdePkg/MdePkg.dec > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > index af002bd98e99..22cf64d9507a 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > @@ -1,7 +1,7 @@ > ## @file > # EBC Debugger configuration application. > # > -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -28,6 +28,13 @@ [Sources] > EbcDebugger/EdbCommon.h > EbcDebugger/EdbSupportString.c > EbcDebugger/EdbSupport.h > + EbcDebugger/EdbCommand.h > + EbcDebugger/EdbHook.h > + EbcDebugger/Edb.h > + EbcDebugger/EdbDisasmSupport.h > + EbcDebugger/EdbDisasm.h > + EbcDebugger/EdbSymbol.h > + EbcDebuggerHook.h Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > [Packages] > MdePkg/MdePkg.dec > -- > 2.18.0.windows.1