From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Fu, Siyuan" <siyuan.fu@intel.com>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to NetworkPkg
Date: Tue, 13 Aug 2019 01:44:51 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C918E0E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190812083729.13864-1-shenglei.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, August 12, 2019 4:37 PM
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan; Wu, Jiaxin; Wang, Jian J; Wu, Hao A
> Subject: [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to
> NetworkPkg
>
> The file MdeModulePkg/Include/Protocol/Dpc.h is consumed
> by the modules in NetworkPkg.
> Hence, this protocol header file should be moved into NetworkPkg.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1949
>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Shenglei Zhang (3):
> NetworkPkg: Add Dpc protocol
> NetworkPkg: Move Dpc.h from MdeModulePkg to NetworkPkg
> MdeModulePkg/MdeModulePkg.dec: Remove gEfiDpcProtocolGuid
I would recommend the below sequence:
Patch 1 (NetworkPkg): Duplicate the Dpc.h file in NetworkPkg, update NetworkPkg.dec
Patch 2 (NetworkPkg): Update the INF files in NetworkPkg to remove MdeModulePkg dependency
Patch 3 (MdeModulePkg): Remove the Dpc.h file in MdeModulePkg, update MdeModulePkg.dec
But if other reviewers are fine with the current series, I am okay with
the current one:
For patch 3/3 (MdeModulePkg part),
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> MdeModulePkg/MdeModulePkg.dec | 3 ---
> NetworkPkg/DpcDxe/DpcDxe.inf | 1 -
> {MdeModulePkg => NetworkPkg}/Include/Protocol/Dpc.h | 0
> NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf | 1 -
> NetworkPkg/NetworkPkg.dec | 4 ++++
> 5 files changed, 4 insertions(+), 5 deletions(-)
> rename {MdeModulePkg => NetworkPkg}/Include/Protocol/Dpc.h (100%)
>
> --
> 2.18.0.windows.1
prev parent reply other threads:[~2019-08-13 1:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 8:37 [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to NetworkPkg Zhang, Shenglei
2019-08-12 8:37 ` [PATCH 1/3] NetworkPkg: Add Dpc protocol Zhang, Shenglei
2019-08-12 9:01 ` Siyuan, Fu
2019-08-12 8:37 ` [PATCH 2/3] NetworkPkg: Move Dpc.h from MdeModulePkg to NetworkPkg Zhang, Shenglei
2019-08-12 9:05 ` [edk2-devel] " Siyuan, Fu
2019-08-12 8:37 ` [PATCH 3/3] MdeModulePkg/MdeModulePkg.dec: Remove gEfiDpcProtocolGuid Zhang, Shenglei
2019-08-13 1:44 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C918E0E@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox