From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Mon, 12 Aug 2019 18:44:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 18:44:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="204925478" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 12 Aug 2019 18:44:53 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 18:44:53 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0439.000; Tue, 13 Aug 2019 09:44:51 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Fu, Siyuan" , "Wu, Jiaxin" , "Wang, Jian J" Subject: Re: [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to NetworkPkg Thread-Topic: [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to NetworkPkg Thread-Index: AQHVUOkyFuCvrmJdwEmqzUwxlOWgwqb4Tgxw Date: Tue, 13 Aug 2019 01:44:51 +0000 Message-ID: References: <20190812083729.13864-1-shenglei.zhang@intel.com> In-Reply-To: <20190812083729.13864-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 4:37 PM > To: devel@edk2.groups.io > Cc: Fu, Siyuan; Wu, Jiaxin; Wang, Jian J; Wu, Hao A > Subject: [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to > NetworkPkg >=20 > The file MdeModulePkg/Include/Protocol/Dpc.h is consumed > by the modules in NetworkPkg. > Hence, this protocol header file should be moved into NetworkPkg. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1949 >=20 > Cc: Siyuan Fu > Cc: Jiaxin Wu > Cc: Jian J Wang > Cc: Hao A Wu > Shenglei Zhang (3): > NetworkPkg: Add Dpc protocol > NetworkPkg: Move Dpc.h from MdeModulePkg to NetworkPkg > MdeModulePkg/MdeModulePkg.dec: Remove gEfiDpcProtocolGuid I would recommend the below sequence: Patch 1 (NetworkPkg): Duplicate the Dpc.h file in NetworkPkg, update Networ= kPkg.dec Patch 2 (NetworkPkg): Update the INF files in NetworkPkg to remove MdeModul= ePkg dependency Patch 3 (MdeModulePkg): Remove the Dpc.h file in MdeModulePkg, update MdeMo= dulePkg.dec But if other reviewers are fine with the current series, I am okay with the current one: For patch 3/3 (MdeModulePkg part), Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > MdeModulePkg/MdeModulePkg.dec | 3 --- > NetworkPkg/DpcDxe/DpcDxe.inf | 1 - > {MdeModulePkg =3D> NetworkPkg}/Include/Protocol/Dpc.h | 0 > NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf | 1 - > NetworkPkg/NetworkPkg.dec | 4 ++++ > 5 files changed, 4 insertions(+), 5 deletions(-) > rename {MdeModulePkg =3D> NetworkPkg}/Include/Protocol/Dpc.h (100%) >=20 > -- > 2.18.0.windows.1