From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Mon, 12 Aug 2019 19:56:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 19:56:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="183748314" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 12 Aug 2019 19:56:19 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 19:56:19 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 19:56:19 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Tue, 13 Aug 2019 10:56:16 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Albecki, Mateusz" CC: Andrew Fish , Laszlo Ersek , "Leif Lindholm" , "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCHv3 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers Thread-Topic: [edk2-devel] [PATCHv3 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers Thread-Index: AQHVTr/YjJr39dyuWUOQRjc8fwAf0qb2vmWAgAGpRrA= Date: Tue, 13 Aug 2019 02:56:16 +0000 Message-ID: References: <20190809143620.4924-1-mateusz.albecki@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Monday, August 12, 2019 10:39 AM > To: Albecki, Mateusz; devel@edk2.groups.io > Cc: Andrew Fish; Laszlo Ersek; Leif Lindholm; Kinney, Michael D; Gao, Li= ming > Subject: Re: [edk2-devel] [PATCHv3 0/4] Add > EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific > programming of UFS host controllers >=20 > > -----Original Message----- > > From: Albecki, Mateusz > > Sent: Friday, August 09, 2019 10:36 PM > > To: devel@edk2.groups.io > > Cc: Albecki, Mateusz; Wu, Hao A > > Subject: [PATCHv3 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to > > support platform specific programming of UFS host controllers > > > > To cover additional host controller programming mentioned in the UFS > > specification we have added an additional protocol that allows the UEF= I > > driver to give control to platform driver. This allows the platform to= perform > > any additional steps needed for the stable operation. > > > > Changes in v3: > > - UFS driver will abort initializaton when it fails to get host contro= ler > > information > > - Fixed bug with calling post link startup callback on failed device d= etection > > > > Test coverage: > > Tested on platform with UFS 2.1 host controller with Samsung UFS2.0 pa= rt > > with 3 LUs enabled All LUs have been enumerated in boot manager. > > Tested that enumeration works without platform protocol installed(on h= ost > > controller that can support it) Tested that enumeration works with > platform > > protocol installed and with additional programming steps after link > > startup(power mode change to GEAR2). > > > > Cc: Hao A Wu > > > > > Mateusz Albecki (4): > > MdeModulePkg: Add definition of the > > EDKII_UFS_HC_PLATFORM_PROTOCOL > > MdeModulePkg/UfsPassThruDxe: Refactor UfsExecUicCommand function > > MdeModulePkg/UfsPassThruDxe: Refactor private data to use > > EDKII_UFS_HC_INFO > > MdeModulePkg/UfsPassThruDxe: Implement > > EDKII_UFS_HC_PLATFORM_PROTOCOL >=20 >=20 > For the 3rd patch, in order to please the PatchCheck.py, I will change t= he > title a little bit to: > * MdeModulePkg/UfsPassThruDxe: Refactor private data to use UfsHcInfo >=20 > Other than that, for the series, > Reviewed-by: Hao A Wu >=20 > Since there is already a confirmation from Laszlo for adding this featur= e in > the upcoming stable tag: > https://edk2.groups.io/g/devel/message/45217?p=3D,,,20,0,0,0::Created,,u= fs,2 > 0,2,0,32784353 >=20 > I plan to push the series tomorrow (after around 24 hours, in case if th= ere > are additional feedbacks). Thanks all, the series has been pushed via commits 12dcad5b1e..ecc32c90ee. Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 26 +++- > > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 44 +++++- > > .../Bus/Ufs/UfsPassThruDxe/UfsPassThruDxe.inf | 3 +- > > .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 173 > +++++++++++++++- > > ----- > > .../Include/Protocol/UfsHostControllerPlatform.h | 124 > +++++++++++++++ > > MdeModulePkg/MdeModulePkg.dec | 3 + > > 6 files changed, 324 insertions(+), 49 deletions(-) > > create mode 100644 > > MdeModulePkg/Include/Protocol/UfsHostControllerPlatform.h > > > > -- > > 2.14.1.windows.1 >=20 >=20 >=20