From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>
Cc: "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry
Date: Thu, 15 Aug 2019 01:09:13 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9199B8@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D11F5@SHSMSX104.ccr.corp.intel.com>
> -----Original Message-----
> From: Gao, Liming
> Sent: Thursday, August 15, 2019 8:26 AM
> To: devel@edk2.groups.io; lersek@redhat.com; Zhang, Shenglei
> Cc: Bi, Dandan; Wu, Hao A
> Subject: RE: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Initialize
> pointer PageMapLevel5Entry
>
> Shenglei:
> The change is good. I agree to add comments for this change purpose like BZ
> https://bugzilla.tianocore.org/show_bug.cgi?id=607
Hello Shenglei,
Could you help to send out a V2 patch to address Laszlo's comments.
Thanks in advance.
Best Regards,
Hao Wu
>
> With this change, Reviewed-by: Liming Gao <liming.gao@intel.com>.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> > Sent: Thursday, August 15, 2019 1:12 AM
> > To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim:
> Initialize pointer PageMapLevel5Entry
> >
> > On 08/14/19 09:37, Zhang, Shenglei wrote:
> > > Initialize PageMapLevel5Entry at the beginning of the function.
> > >
> > > This commit will fix a GCC 4.8.5 build failure introduced by commit
> > > b3527dedc3951f061c5a73cb4fb2b0f95f47e08b.
> > >
> > > OvmfPkg build failure wtih gcc 4.8.5 still exists at latest edk2 version.
> > > The commit 46f8a6891606746ca8b1e684ac379ce271306dc0 seems not to
> fix
> > > the build failure completely.
> > >
> > > Cc: Dandan Bi <dandan.bi@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > > ---
> > > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
> b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
> > > index 2389f3eb485b..aae80536ac3d 100644
> > > --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
> > > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
> > > @@ -652,6 +652,8 @@ CreateIdentityMappingPageTables (
> > > UINT64 AddressEncMask;
> > > IA32_CR4 Cr4;
> > >
> > > + PageMapLevel5Entry = NULL;
> > > +
> > > //
> > > // Make sure AddressEncMask is contained to smallest supported
> address field
> > > //
> > >
> >
> > If you are convinced that we need this assignment *only* for suppressing
> > an invalid compiler warning, then please add a comment about it:
> >
> > //
> > // set PageMapLevel5Entry to suppress incorrect compiler/analyzer
> > // warnings
> > //
> >
> > Related documentation BZ:
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=607
> >
> > ... Just a suggestion from my side; I defer to the MdeModulePkg
> maintainers.
> >
> > Thanks
> > Laszlo
> >
> >
prev parent reply other threads:[~2019-08-15 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 7:37 [PATCH 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry Zhang, Shenglei
2019-08-14 17:11 ` [edk2-devel] " Laszlo Ersek
2019-08-15 0:25 ` Liming Gao
2019-08-15 1:09 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C9199B8@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox