From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: hao.a.wu@intel.com)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by groups.io with SMTP; Wed, 14 Aug 2019 18:12:34 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
  by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 18:12:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,387,1559545200"; 
   d="scan'208";a="352092583"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
  by orsmga005.jf.intel.com with ESMTP; 14 Aug 2019 18:12:33 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 14 Aug 2019 18:12:33 -0700
Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by
 fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 14 Aug 2019 18:12:33 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by
 SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000;
 Thu, 15 Aug 2019 09:12:31 +0800
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Xu, Wei6" <wei6.xu@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve comparisons in CapsuleOnDisk.c
Thread-Topic: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve
 comparisons in CapsuleOnDisk.c
Thread-Index: AQHVUcVZfKNDvgm0bEK2b3JT/NVybab7aUaQ
Date: Thu, 15 Aug 2019 01:12:31 +0000
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9199D4@SHSMSX104.ccr.corp.intel.com>
References: <20190813105317.2820-1-wei6.xu@intel.com>
In-Reply-To: <20190813105317.2820-1-wei6.xu@intel.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: hao.a.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> -----Original Message-----
> From: Xu, Wei6
> Sent: Tuesday, August 13, 2019 6:53 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Gao, Liming
> Subject: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve
> comparisons in CapsuleOnDisk.c
>=20
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2028
>=20
> Non-Boolean comparisons should use a compare operator
> (=3D=3D, !=3D, >, < >=3D, <=3D).
>=20
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
> ---
>  MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> index 382efa9aa0..b161d1a981 100644
> --- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> @@ -742,11 +742,11 @@ IsCapsuleOnDiskSupported (
>                    );
>    if (EFI_ERROR (Status)) {
>      return FALSE;
>    }
>=20
> -  if (OsIndicationsSupported &
> EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY_SUPPORTED) {
> +  if ((OsIndicationsSupported &
> EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY_SUPPORTED) !=3D 0) {
>      return TRUE;
>    }


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Pushed via commit 34651e7d76.

Best Regards,
Hao Wu


>=20
>    return FALSE;
>  }
> --
> 2.16.2.windows.1