From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Thu, 15 Aug 2019 00:23:27 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2019 00:23:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,388,1559545200"; d="scan'208";a="167672008" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 15 Aug 2019 00:23:26 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 00:23:26 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 00:23:26 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0439.000; Thu, 15 Aug 2019 15:23:24 +0800 From: "Wu, Hao A" To: "Gao, Liming" , "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Bi, Dandan" Subject: Re: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry Thread-Topic: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry Thread-Index: AQHVUxBqF3nxGlLlHkSf8j3m1V7dKqb69ZEAgADYdHA= Date: Thu, 15 Aug 2019 07:23:23 +0000 Message-ID: References: <20190815022314.8244-1-shenglei.zhang@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D13D7@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D13D7@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Liming > Sent: Thursday, August 15, 2019 10:27 AM > To: Zhang, Shenglei; devel@edk2.groups.io > Cc: Bi, Dandan; Wu, Hao A > Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer > PageMapLevel5Entry >=20 > Shenglei: >=20 > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Thursday, August 15, 2019 10:23 AM > > To: devel@edk2.groups.io > > Cc: Bi, Dandan ; Gao, Liming > ; Wu, Hao A > > Subject: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer > PageMapLevel5Entry > > > > Initialize PageMapLevel5Entry at the beginning of the function. > > > > This commit will fix a GCC 4.8.5 build failure introduced by commit > > b3527dedc3951f061c5a73cb4fb2b0f95f47e08b. > > > > OvmfPkg build failure wtih gcc 4.8.5 still exists at latest edk2 versio= n. > > The commit 46f8a6891606746ca8b1e684ac379ce271306dc0 seems not to fix > > the build failure completely. > > > > Cc: Dandan Bi > > Cc: Liming Gao > > Cc: Hao A Wu > > Signed-off-by: Shenglei Zhang > > --- > > v2: Add comments to state why set initialize to NULL. > > > > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > > index 2389f3eb485b..2f1038b1e67e 100644 > > --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > > @@ -652,6 +652,11 @@ CreateIdentityMappingPageTables ( > > UINT64 AddressEncMask; > > IA32_CR4 Cr4; > > > > + // > > + // set PageMapLevel5Entry to suppress incorrect compiler/analyzer > warnigns >=20 > Please fix the typo warnigns =3D=3D> warnings Hello Liming, I will fix the above typo when I push the patch. Also, I will keep your RB tag from V1 patch since there is only comment change between the two versions. Best Regards, Hao Wu >=20 > Thanks > Liming > > + // > > + PageMapLevel5Entry =3D NULL; > > + > > // > > // Make sure AddressEncMask is contained to smallest supported addre= ss > field > > // > > -- > > 2.18.0.windows.1