From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry
Date: Fri, 16 Aug 2019 01:05:35 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C91A1D4@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D1948@SHSMSX104.ccr.corp.intel.com>
> -----Original Message-----
> From: Gao, Liming
> Sent: Thursday, August 15, 2019 4:31 PM
> To: Wu, Hao A; Zhang, Shenglei; devel@edk2.groups.io
> Cc: Bi, Dandan
> Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer
> PageMapLevel5Entry
>
> That's fine. Thanks!
>
> >-----Original Message-----
> >From: Wu, Hao A
> >Sent: Thursday, August 15, 2019 3:23 PM
> >To: Gao, Liming <liming.gao@intel.com>; Zhang, Shenglei
> ><shenglei.zhang@intel.com>; devel@edk2.groups.io
> >Cc: Bi, Dandan <dandan.bi@intel.com>
> >Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer
> >PageMapLevel5Entry
> >
> >> -----Original Message-----
> >> From: Gao, Liming
> >> Sent: Thursday, August 15, 2019 10:27 AM
> >> To: Zhang, Shenglei; devel@edk2.groups.io
> >> Cc: Bi, Dandan; Wu, Hao A
> >> Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer
> >> PageMapLevel5Entry
> >>
> >> Shenglei:
> >>
> >> > -----Original Message-----
> >> > From: Zhang, Shenglei
> >> > Sent: Thursday, August 15, 2019 10:23 AM
> >> > To: devel@edk2.groups.io
> >> > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> >> <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> >> > Subject: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer
> >> PageMapLevel5Entry
> >> >
> >> > Initialize PageMapLevel5Entry at the beginning of the function.
> >> >
> >> > This commit will fix a GCC 4.8.5 build failure introduced by commit
> >> > b3527dedc3951f061c5a73cb4fb2b0f95f47e08b.
> >> >
> >> > OvmfPkg build failure wtih gcc 4.8.5 still exists at latest edk2 version.
> >> > The commit 46f8a6891606746ca8b1e684ac379ce271306dc0 seems not to
> fix
> >> > the build failure completely.
> >> >
> >> > Cc: Dandan Bi <dandan.bi@intel.com>
> >> > Cc: Liming Gao <liming.gao@intel.com>
> >> > Cc: Hao A Wu <hao.a.wu@intel.com>
> >> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> >> > ---
> >> > v2: Add comments to state why set initialize to NULL.
> >> >
> >> > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 +++++
> >> > 1 file changed, 5 insertions(+)
> >> >
> >> > diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
> >> b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
> >> > index 2389f3eb485b..2f1038b1e67e 100644
> >> > --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
> >> > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
> >> > @@ -652,6 +652,11 @@ CreateIdentityMappingPageTables (
> >> > UINT64 AddressEncMask;
> >> > IA32_CR4 Cr4;
> >> >
> >> > + //
> >> > + // set PageMapLevel5Entry to suppress incorrect compiler/analyzer
> >> warnigns
> >>
> >> Please fix the typo warnigns ==> warnings
> >
> >
> >Hello Liming,
> >
> >I will fix the above typo when I push the patch.
> >Also, I will keep your RB tag from V1 patch since there is only comment
> >change between the two versions.
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
With the above typo fixed, pushed via commit 0680d08683.
Best Regards,
Hao Wu
> >
> >Best Regards,
> >Hao Wu
> >
> >
> >>
> >> Thanks
> >> Liming
> >> > + //
> >> > + PageMapLevel5Entry = NULL;
> >> > +
> >> > //
> >> > // Make sure AddressEncMask is contained to smallest supported
> >address
> >> field
> >> > //
> >> > --
> >> > 2.18.0.windows.1
prev parent reply other threads:[~2019-08-16 1:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 2:23 [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry Zhang, Shenglei
2019-08-15 2:26 ` Liming Gao
2019-08-15 7:23 ` Wu, Hao A
2019-08-15 8:31 ` Liming Gao
2019-08-16 1:05 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C91A1D4@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox