From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: hao.a.wu@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Mon, 26 Aug 2019 20:03:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 20:03:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,435,1559545200"; d="scan'208";a="174410313" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 26 Aug 2019 20:03:02 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 20:03:02 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 20:03:01 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.204]) with mapi id 14.03.0439.000; Tue, 27 Aug 2019 11:02:59 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Zurcher, Christopher J" CC: "Kinney, Michael D" , "Yao, Jiewen" , "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v5 0/4] Add SCSI Support for Storage Security Command Protocol Thread-Topic: [edk2-devel] [PATCH v5 0/4] Add SCSI Support for Storage Security Command Protocol Thread-Index: AQHVWTVIQCHxQaM8QUqHdcBKQ4eT7acOOCxg Date: Tue, 27 Aug 2019 03:02:58 +0000 Message-ID: References: <20190822220215.24536-1-christopher.j.zurcher@intel.com> In-Reply-To: <20190822220215.24536-1-christopher.j.zurcher@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Friday, August 23, 2019 6:02 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Hao A > Subject: [edk2-devel] [PATCH v5 0/4] Add SCSI Support for Storage Securi= ty > Command Protocol >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1546 Hello, One general comment: Please help to add the above BZ reference information in the commit log me= ssage of every patch in the proposed series. Thanks. Best Regards, Hao Wu >=20 > V5 changes: > Split MdeModulePkg changes into separate patches. Add ReinstallProtocol > calls for StorageSecurityCommand Protocol. Restore original MediaPresent > and ReadCapacity behavior, with new implementation for WLUN type media. > Clear temporary aligned buffers before freeing them. >=20 > V4 changes: > Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. > Add error handling for (BlockSize =3D=3D 0) in Read and WriteBlocks comm= ands > to handle partitions that do not support ReadCapacity(). >=20 > V3 changes: > Initialize AlignedBuffer variable in ScsiDiskReceiveData and > ScsiDiskSendData functions. Remove redundant input validation and debug > message in ScsiDiskSendData. >=20 > V2 changes: > Split the patch into separate commits for separate packages. >=20 > To support RPMB access on UFS devices, support must be added to > the ScsiDiskDxe driver for the Storage Security Command Protocol. >=20 > Cc: Michael D Kinney > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Liming Gao > Cc: Hao A Wu >=20 > Christopher J Zurcher (4): > MdePkg: Implement SCSI commands for Security Protocol In/Out > MdeModulePkg/UfsPassThruDxe: Check for RPMB W-LUN (SecurityLun) > MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check > MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol >=20 > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 +++++- > MdePkg/Include/IndustryStandard/Scsi.h | 48 +- > MdePkg/Include/Library/UefiScsiLib.h | 126 +++- > MdePkg/Include/Protocol/ScsiIo.h | 9 +- > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 614 > +++++++++++++++++++- > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 17 +- > MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 205 ++++++- > 9 files changed, 1157 insertions(+), 41 deletions(-) >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20