From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Zeng, Star" <star.zeng@intel.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg
Date: Wed, 28 Aug 2019 01:58:22 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C91E579@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB048310403A870A@shsmsx102.ccr.corp.intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zeng, Star
> Sent: Wednesday, August 28, 2019 8:48 AM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Zeng, Star
> Subject: Re: [edk2-devel] [PATCH 0/2] move
> PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg
>
> Both XXXPkg.uni need to be updated as the PCD movement.
Agree.
> With that, Reviewed-by: Star Zeng <star.zeng@intel.com>
Found that the PCD was introduced by commit f8ea30263c. At that time, the
PcatRealTimeClockRuntimeDxe driver was still in MdeModulePkg. Then commit
345e5a6556 moved the driver to PcAtChipsetPkg but forgot to move the PCD.
With Star's comment addressed, for the series:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Also, please help to hold the patch after the upcoming stable tag, thanks.
Best Regards,
Hao Wu
>
> Thanks,
> Star
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ni,
> > Ray
> > Sent: Wednesday, August 28, 2019 7:27 AM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout
> > from MdeModulePkg to PcAtChipsetPkg
> >
> >
> > Ray Ni (2):
> > PcAtChipsetPkg: add PcdRealTimeClockUpdateTimeout
> > MdeModulePkg: Remove PcdRealTimeClockUpdateTimeout
> >
> > MdeModulePkg/MdeModulePkg.dec | 4 ----
> > PcAtChipsetPkg/PcAtChipsetPkg.dec | 6 +++++-
> > .../PcatRealTimeClockRuntimeDxe.inf | 5 ++---
> > 3 files changed, 7 insertions(+), 8 deletions(-)
> >
> > --
> > 2.21.0.windows.1
> >
> >
> >
>
>
>
prev parent reply other threads:[~2019-08-28 1:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 23:27 [PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg Ni, Ray
2019-08-27 23:27 ` [PATCH 1/2] PcAtChipsetPkg: add PcdRealTimeClockUpdateTimeout Ni, Ray
2019-08-27 23:27 ` [PATCH 2/2] MdeModulePkg: Remove PcdRealTimeClockUpdateTimeout Ni, Ray
2019-08-28 0:48 ` [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg Zeng, Star
2019-08-28 1:58 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C91E579@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox