From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Tue, 27 Aug 2019 18:58:26 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2019 18:58:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,439,1559545200"; d="scan'208";a="180402459" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 27 Aug 2019 18:58:25 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 27 Aug 2019 18:58:25 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Aug 2019 18:58:24 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Aug 2019 18:58:24 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Wed, 28 Aug 2019 09:58:23 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Zeng, Star" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg Thread-Topic: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg Thread-Index: AQHVXS8d2st31Di/TUWSF/W1g3NbA6cPNAMAgACYQYA= Date: Wed, 28 Aug 2019 01:58:22 +0000 Message-ID: References: <20190827232725.233124-1-ray.ni@intel.com> <0C09AFA07DD0434D9E2A0C6AEB048310403A870A@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB048310403A870A@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zeng, Star > Sent: Wednesday, August 28, 2019 8:48 AM > To: devel@edk2.groups.io; Ni, Ray > Cc: Zeng, Star > Subject: Re: [edk2-devel] [PATCH 0/2] move > PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg >=20 > Both XXXPkg.uni need to be updated as the PCD movement. Agree. > With that, Reviewed-by: Star Zeng Found that the PCD was introduced by commit f8ea30263c. At that time, the PcatRealTimeClockRuntimeDxe driver was still in MdeModulePkg. Then commit 345e5a6556 moved the driver to PcAtChipsetPkg but forgot to move the PCD. With Star's comment addressed, for the series: Reviewed-by: Hao A Wu Also, please help to hold the patch after the upcoming stable tag, thanks. Best Regards, Hao Wu >=20 > Thanks, > Star >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ni, > > Ray > > Sent: Wednesday, August 28, 2019 7:27 AM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout > > from MdeModulePkg to PcAtChipsetPkg > > > > > > Ray Ni (2): > > PcAtChipsetPkg: add PcdRealTimeClockUpdateTimeout > > MdeModulePkg: Remove PcdRealTimeClockUpdateTimeout > > > > MdeModulePkg/MdeModulePkg.dec | 4 ---- > > PcAtChipsetPkg/PcAtChipsetPkg.dec | 6 +++++= - > > .../PcatRealTimeClockRuntimeDxe.inf | 5 ++--- > > 3 files changed, 7 insertions(+), 8 deletions(-) > > > > -- > > 2.21.0.windows.1 > > > > > > >=20 >=20 >=20