From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: hao.a.wu@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Tue, 03 Sep 2019 20:39:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2019 20:39:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,465,1559545200"; d="scan'208";a="334067328" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 03 Sep 2019 20:39:35 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 20:39:34 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 20:39:34 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.89]) with mapi id 14.03.0439.000; Wed, 4 Sep 2019 11:39:33 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , Tyler Erickson CC: "Ni, Ray" Subject: Re: [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs for Admin commands Thread-Topic: [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs for Admin commands Thread-Index: AQHVYl6z6TLE16n3R0SRB+RHQp7J36ca36ZggAAAQnA= Date: Wed, 4 Sep 2019 03:39:32 +0000 Message-ID: References: <20190903135457.26560-1-tyler.j.erickson@seagate.com> <20190903135457.26560-2-tyler.j.erickson@seagate.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Wu, Hao A > Sent: Wednesday, September 04, 2019 11:39 AM > To: devel@edk2.groups.io; Tyler Erickson > Cc: Wu, Hao A; Ni, Ray > Subject: [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs > for Admin commands >=20 > Repost the mail to the list. >=20 > Best Regards, > Hao Wu >=20 > -----Original Message----- > From: Tyler Erickson [mailto:tyler.j.erickson@seagate.com] > Sent: Tuesday, September 03, 2019 9:55 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Ni, Ray > Subject: [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs > for Admin commands >=20 > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Tyler Erickson > --- > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > index 8e721379466a..78a3c663ded4 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > @@ -561,7 +561,7 @@ NvmExpressPassThru ( > Sq =3D Private->SqBuffer[QueueId] + Private->SqTdbl[QueueId].Sqt; > Cq =3D Private->CqBuffer[QueueId] + Private->CqHdbl[QueueId].Cqh; >=20 > - if (Packet->NvmeCmd->Nsid !=3D NamespaceId) { > + if (Packet->QueueType !=3D NVME_ADMIN_QUEUE && Packet->NvmeCmd- > >Nsid !=3D NamespaceId) { Hello, Per my understanding to the codes, I think the: * Input parameter 'NamespaceId' for the PassThru() service * The 'Nsid' field of the EFI_NVM_EXPRESS_COMMAND are of the same meaning. Do you think setting these 2 values identical when calling the PassThru() service can resolve the issue you met? Best Regards, Hao Wu > return EFI_INVALID_PARAMETER; > } >=20 > -- > 2.17.1