Re: [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, September 05, 2019 3:47 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in
> SerialDxe.inf
> 
> FILE GUID in MdeModulePkg\Universal\SerialDxe\SerialDxe.inf is
> same to the one gEdkiiSerialPortLibVendorGuid.


The reason that these two GUIDs are identical roots from the fact that before
commit cf78c9d18a:
* MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID

the SerialDxe driver uses its own FILE_GUID for constructing a device path node
on a handle that it creates. And PlatformBootManagerLib instances have to refer
to this FILE_GUID.

After commits b0663641c9..fec63bb922, a new definition
EDKII_SERIAL_PORT_LIB_VENDOR_GUID was added (which has the same value with the
FILE_GUID of SerialDxe), so that consumers can use this one instead and the
compatibility is also kept.


> Its FILE GUID should be updated to another value.


Since all the PlatformBootManagerLib instances have been updated to use
EDKII_SERIAL_PORT_LIB_VENDOR_GUID, it should be safe to change the FILE_GUID of
SerialDxe. So for the patch:

Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> https://bugzilla.tianocore.org/show_bug.cgi?id=2144
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> index b6c85b3f848d..ab5e045ead3d 100644
> --- a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> +++ b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> @@ -11,7 +11,7 @@ [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = SerialDxe
>    MODULE_UNI_FILE                = SerialDxe.uni
> -  FILE_GUID                      = D3987D4B-971A-435F-8CAF-4967EB627241
> +  FILE_GUID                      = 3bd86846-4ad0-4e94-81e6-9ea34cd34cxb
>    MODULE_TYPE                    = DXE_DRIVER
>    VERSION_STRING                 = 1.0
> 
> --
> 2.18.0.windows.1