From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Sun, 08 Sep 2019 18:20:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Sep 2019 18:20:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,483,1559545200"; d="scan'208";a="199955374" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 08 Sep 2019 18:20:37 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Sep 2019 18:20:36 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Sep 2019 18:20:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Mon, 9 Sep 2019 09:20:35 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf Thread-Topic: [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf Thread-Index: AQHVY74uqpddUJwlwUWgR2gl/28C5qccxnuw Date: Mon, 9 Sep 2019 01:20:35 +0000 Message-ID: References: <20190905074722.13564-1-shenglei.zhang@intel.com> <20190905074722.13564-3-shenglei.zhang@intel.com> In-Reply-To: <20190905074722.13564-3-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, September 05, 2019 3:47 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in > SerialDxe.inf >=20 > FILE GUID in MdeModulePkg\Universal\SerialDxe\SerialDxe.inf is > same to the one gEdkiiSerialPortLibVendorGuid. The reason that these two GUIDs are identical roots from the fact that befo= re commit cf78c9d18a: * MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID the SerialDxe driver uses its own FILE_GUID for constructing a device path = node on a handle that it creates. And PlatformBootManagerLib instances have to r= efer to this FILE_GUID. After commits b0663641c9..fec63bb922, a new definition EDKII_SERIAL_PORT_LIB_VENDOR_GUID was added (which has the same value with = the FILE_GUID of SerialDxe), so that consumers can use this one instead and the compatibility is also kept. > Its FILE GUID should be updated to another value. Since all the PlatformBootManagerLib instances have been updated to use EDKII_SERIAL_PORT_LIB_VENDOR_GUID, it should be safe to change the FILE_GUI= D of SerialDxe. So for the patch: Reviewed-by: Hao A Wu Best Regards, Hao Wu > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2144 >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > index b6c85b3f848d..ab5e045ead3d 100644 > --- a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > +++ b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > @@ -11,7 +11,7 @@ [Defines] > INF_VERSION =3D 0x00010005 > BASE_NAME =3D SerialDxe > MODULE_UNI_FILE =3D SerialDxe.uni > - FILE_GUID =3D D3987D4B-971A-435F-8CAF-4967EB62724= 1 > + FILE_GUID =3D 3bd86846-4ad0-4e94-81e6-9ea34cd34cx= b > MODULE_TYPE =3D DXE_DRIVER > VERSION_STRING =3D 1.0 >=20 > -- > 2.18.0.windows.1