* [PATCH 0/2] Update file guids in INF files
@ 2019-09-05 7:47 Zhang, Shenglei
2019-09-05 7:47 ` [PATCH 1/2] EmulatorPkg/PeiEmuSerialPortLib: Update the INF file Guid Zhang, Shenglei
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Zhang, Shenglei @ 2019-09-05 7:47 UTC (permalink / raw)
To: devel; +Cc: Jordan Justen, Andrew Fish, Ray Ni, Jian J Wang, Hao A Wu
The file guids of PeiEmuSerialPortLib.inf and SerialDxe.inf
are same to other guids. So update them to new ones.
https://bugzilla.tianocore.org/show_bug.cgi?id=2144
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Shenglei Zhang (1):
MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf
shenglei (1):
EmulatorPkg/PeiEmuSerialPortLib: Update the INF file Guid
EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf | 2 +-
MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] EmulatorPkg/PeiEmuSerialPortLib: Update the INF file Guid
2019-09-05 7:47 [PATCH 0/2] Update file guids in INF files Zhang, Shenglei
@ 2019-09-05 7:47 ` Zhang, Shenglei
2019-09-05 7:47 ` [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf Zhang, Shenglei
[not found] ` <15C17B3D71A3600C.31066@groups.io>
2 siblings, 0 replies; 5+ messages in thread
From: Zhang, Shenglei @ 2019-09-05 7:47 UTC (permalink / raw)
To: devel; +Cc: shenglei, Jordan Justen, Andrew Fish, Ray Ni
From: shenglei <shenglei.zhang@intel.com>
FILE GUID in PeiEmuSerialPortLib.inf is same to
MdePkg\Library\BaseSerialPortLibNull\BaseSerialPortLibNull.inf.
PeiEmuSerialPortLib.inf FILE_GUID should be updated.
https://bugzilla.tianocore.org/show_bug.cgi?id=2144
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf b/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
index f61346174739..2f5e656fd753 100644
--- a/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
+++ b/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
@@ -12,7 +12,7 @@
[Defines]
INF_VERSION = 0x00010005
BASE_NAME = PeiEmuSerialPortLibNull
- FILE_GUID = E4541241-8897-411a-91F8-7D7E45837146
+ FILE_GUID = 76003416-0373-4C3C-BC4C-87E367FD4BD1
MODULE_TYPE = PEIM
VERSION_STRING = 1.0
LIBRARY_CLASS = SerialPortLib| PEI_CORE PEIM SEC
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf
2019-09-05 7:47 [PATCH 0/2] Update file guids in INF files Zhang, Shenglei
2019-09-05 7:47 ` [PATCH 1/2] EmulatorPkg/PeiEmuSerialPortLib: Update the INF file Guid Zhang, Shenglei
@ 2019-09-05 7:47 ` Zhang, Shenglei
2019-09-09 1:20 ` Wu, Hao A
[not found] ` <15C17B3D71A3600C.31066@groups.io>
2 siblings, 1 reply; 5+ messages in thread
From: Zhang, Shenglei @ 2019-09-05 7:47 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Hao A Wu
FILE GUID in MdeModulePkg\Universal\SerialDxe\SerialDxe.inf is
same to the one gEdkiiSerialPortLibVendorGuid.
Its FILE GUID should be updated to another value.
https://bugzilla.tianocore.org/show_bug.cgi?id=2144
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
index b6c85b3f848d..ab5e045ead3d 100644
--- a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
+++ b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
@@ -11,7 +11,7 @@ [Defines]
INF_VERSION = 0x00010005
BASE_NAME = SerialDxe
MODULE_UNI_FILE = SerialDxe.uni
- FILE_GUID = D3987D4B-971A-435F-8CAF-4967EB627241
+ FILE_GUID = 3bd86846-4ad0-4e94-81e6-9ea34cd34cxb
MODULE_TYPE = DXE_DRIVER
VERSION_STRING = 1.0
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf
2019-09-05 7:47 ` [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf Zhang, Shenglei
@ 2019-09-09 1:20 ` Wu, Hao A
0 siblings, 0 replies; 5+ messages in thread
From: Wu, Hao A @ 2019-09-09 1:20 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Wang, Jian J
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, September 05, 2019 3:47 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in
> SerialDxe.inf
>
> FILE GUID in MdeModulePkg\Universal\SerialDxe\SerialDxe.inf is
> same to the one gEdkiiSerialPortLibVendorGuid.
The reason that these two GUIDs are identical roots from the fact that before
commit cf78c9d18a:
* MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
the SerialDxe driver uses its own FILE_GUID for constructing a device path node
on a handle that it creates. And PlatformBootManagerLib instances have to refer
to this FILE_GUID.
After commits b0663641c9..fec63bb922, a new definition
EDKII_SERIAL_PORT_LIB_VENDOR_GUID was added (which has the same value with the
FILE_GUID of SerialDxe), so that consumers can use this one instead and the
compatibility is also kept.
> Its FILE GUID should be updated to another value.
Since all the PlatformBootManagerLib instances have been updated to use
EDKII_SERIAL_PORT_LIB_VENDOR_GUID, it should be safe to change the FILE_GUID of
SerialDxe. So for the patch:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> https://bugzilla.tianocore.org/show_bug.cgi?id=2144
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> index b6c85b3f848d..ab5e045ead3d 100644
> --- a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> +++ b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> @@ -11,7 +11,7 @@ [Defines]
> INF_VERSION = 0x00010005
> BASE_NAME = SerialDxe
> MODULE_UNI_FILE = SerialDxe.uni
> - FILE_GUID = D3987D4B-971A-435F-8CAF-4967EB627241
> + FILE_GUID = 3bd86846-4ad0-4e94-81e6-9ea34cd34cxb
> MODULE_TYPE = DXE_DRIVER
> VERSION_STRING = 1.0
>
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <15C17B3D71A3600C.31066@groups.io>]
end of thread, other threads:[~2019-09-16 6:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-05 7:47 [PATCH 0/2] Update file guids in INF files Zhang, Shenglei
2019-09-05 7:47 ` [PATCH 1/2] EmulatorPkg/PeiEmuSerialPortLib: Update the INF file Guid Zhang, Shenglei
2019-09-05 7:47 ` [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf Zhang, Shenglei
2019-09-09 1:20 ` Wu, Hao A
[not found] ` <15C17B3D71A3600C.31066@groups.io>
[not found] ` <C0706E73DB8C124D9B9C38AA364E5D5E0562C748@SHSMSX106.ccr.corp.intel.com>
2019-09-16 6:38 ` [edk2-devel] [PATCH 1/2] EmulatorPkg/PeiEmuSerialPortLib: Update the INF file Guid Ni, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox