From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Mon, 09 Sep 2019 00:02:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 00:02:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,484,1559545200"; d="scan'208";a="191425008" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 09 Sep 2019 00:02:37 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 9 Sep 2019 00:02:37 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 9 Sep 2019 00:02:37 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.235]) with mapi id 14.03.0439.000; Mon, 9 Sep 2019 15:02:34 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Zurcher, Christopher J" , "Gao, Liming" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v6 0/4] Add SCSI Support for Storage Security Command Protocol Thread-Topic: [edk2-devel] [PATCH v6 0/4] Add SCSI Support for Storage Security Command Protocol Thread-Index: AQHVZQAnHj/tTs0oCkKd3gVN0zqqDaci2mdg Date: Mon, 9 Sep 2019 07:02:34 +0000 Message-ID: References: <20190906221217.34180-1-christopher.j.zurcher@intel.com> In-Reply-To: <20190906221217.34180-1-christopher.j.zurcher@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Saturday, September 07, 2019 6:12 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Hao A > Subject: [edk2-devel] [PATCH v6 0/4] Add SCSI Support for Storage Securi= ty > Command Protocol >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1546 >=20 > V6 changes: > Restore EFI_SCSI_TYPE defines for ASC IT8 devices. Revert EFI_SCSI_IO_TY= PE > changes in Protocol\ScsiIo.h. Add INC_512 parameter for SecurityProtocol > In/Out commands in UefiScsiLib. Change UINT32 args to UINTN to match the > definitions for Storage Security Command Protocol. >=20 > V5 changes: > Split MdeModulePkg changes into separate patches. Add ReinstallProtocol > calls for StorageSecurityCommand Protocol. Restore original MediaPresent > and ReadCapacity behavior, with new implementation for WLUN type media. > Clear temporary aligned buffers before freeing them. >=20 > V4 changes: > Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. > Add error handling for (BlockSize =3D=3D 0) in Read and WriteBlocks comm= ands > to handle partitions that do not support ReadCapacity(). >=20 > V3 changes: > Initialize AlignedBuffer variable in ScsiDiskReceiveData and > ScsiDiskSendData functions. Remove redundant input validation and debug > message in ScsiDiskSendData. >=20 > V2 changes: > Split the patch into separate commits for separate packages. >=20 > To support RPMB access on UFS devices, support must be added to > the ScsiDiskDxe driver for the Storage Security Command Protocol. >=20 > Cc: Michael D Kinney > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Liming Gao > Cc: Hao A Wu >=20 > Christopher J Zurcher (4): > MdePkg: Implement SCSI commands for Security Protocol In/Out > MdeModulePkg/UfsPassThruDxe: Check for RPMB W-LUN (SecurityLun) > MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check > MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol For the MdeModulePkg changes (patch 2 to 4): Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 +++++- > MdePkg/Include/IndustryStandard/Scsi.h | 48 +- > MdePkg/Include/Library/UefiScsiLib.h | 128 +++- > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 616 > +++++++++++++++++++- > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 17 +- > MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 217 ++++++- > 8 files changed, 1167 insertions(+), 38 deletions(-) >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20