From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: hao.a.wu@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Mon, 09 Sep 2019 00:05:42 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 00:05:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,484,1559545200"; d="scan'208";a="191426486" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 09 Sep 2019 00:05:41 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 9 Sep 2019 00:05:41 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 9 Sep 2019 00:05:41 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.86]) with mapi id 14.03.0439.000; Mon, 9 Sep 2019 15:05:39 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Zurcher, Christopher J" CC: "Yao, Jiewen" , "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v6 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out Thread-Topic: [edk2-devel] [PATCH v6 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out Thread-Index: AQHVZQAznt15nKobdk6xrn4gU5a/s6ci4bFg Date: Mon, 9 Sep 2019 07:05:38 +0000 Message-ID: References: <20190906221217.34180-1-christopher.j.zurcher@intel.com> <20190906221217.34180-2-christopher.j.zurcher@intel.com> In-Reply-To: <20190906221217.34180-2-christopher.j.zurcher@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello, One inline comment below: > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Saturday, September 07, 2019 6:12 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen; Wang, Jian J; Gao, Liming > Subject: [edk2-devel] [PATCH v6 1/4] MdePkg: Implement SCSI commands > for Security Protocol In/Out >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1546 >=20 > This patch implements the Security Protocol In and Security Protocol Out > commands in UefiScsiLib to prepare support for the Storage Security > Command Protocol. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Liming Gao > Signed-off-by: Christopher J Zurcher > --- > MdePkg/Include/IndustryStandard/Scsi.h | 48 +++-- > MdePkg/Include/Library/UefiScsiLib.h | 128 +++++++++++- > MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 217 +++++++++++++++++++- > 3 files changed, 374 insertions(+), 19 deletions(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/Scsi.h > b/MdePkg/Include/IndustryStandard/Scsi.h > index cbe5709fe5..d03886417f 100644 > --- a/MdePkg/Include/IndustryStandard/Scsi.h > +++ b/MdePkg/Include/IndustryStandard/Scsi.h > @@ -1,7 +1,7 @@ > /** @file > Support for SCSI-2 standard >=20 > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved. > + Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -163,6 +163,12 @@ > #define EFI_SCSI_OP_SEND_MESSAGE10 0x2a > #define EFI_SCSI_OP_SEND_MESSAGE12 0xaa >=20 > +// > +// Additional commands for Secure Transactions > +// > +#define EFI_SCSI_OP_SECURITY_PROTOCOL_IN 0xa2 > +#define EFI_SCSI_OP_SECURITY_PROTOCOL_OUT 0xb5 > + > // > // SCSI Data Transfer Direction > // > @@ -172,22 +178,30 @@ > // > // Peripheral Device Type Definitions > // > -#define EFI_SCSI_TYPE_DISK 0x00 ///< Direct-access device (e.= g. > magnetic disk) > -#define EFI_SCSI_TYPE_TAPE 0x01 ///< Sequential-access device= (e.g. > magnetic tape) > -#define EFI_SCSI_TYPE_PRINTER 0x02 ///< Printer device > -#define EFI_SCSI_TYPE_PROCESSOR 0x03 ///< Processor device > -#define EFI_SCSI_TYPE_WORM 0x04 ///< Write-once device (e.g. = some > optical disks) > -#define EFI_SCSI_TYPE_CDROM 0x05 ///< CD-ROM device > -#define EFI_SCSI_TYPE_SCANNER 0x06 ///< Scanner device > -#define EFI_SCSI_TYPE_OPTICAL 0x07 ///< Optical memory device (e= .g. > some optical disks) > -#define EFI_SCSI_TYPE_MEDIUMCHANGER 0x08 ///< Medium changer > device (e.g. jukeboxes) > -#define EFI_SCSI_TYPE_COMMUNICATION 0x09 ///< Communications > device > -#define EFI_SCSI_TYPE_ASCIT8_1 0x0A ///< Defined by ASC IT8 (Grap= hic > arts pre-press devices) > -#define EFI_SCSI_TYPE_ASCIT8_2 0x0B ///< Defined by ASC IT8 (Grap= hic > arts pre-press devices) > -// > -// 0Ch - 1Eh are reserved > -// > -#define EFI_SCSI_TYPE_UNKNOWN 0x1F ///< Unknown or no device > type > +#define EFI_SCSI_TYPE_DISK 0x00 ///< Direct-access device (= e.g. > magnetic disk) > +#define EFI_SCSI_TYPE_TAPE 0x01 ///< Sequential-access devi= ce (e.g. > magnetic tape) > +#define EFI_SCSI_TYPE_PRINTER 0x02 ///< Printer device > +#define EFI_SCSI_TYPE_PROCESSOR 0x03 ///< Processor device > +#define EFI_SCSI_TYPE_WORM 0x04 ///< Write-once device (e.g= . > some optical disks) > +#define EFI_SCSI_TYPE_CDROM 0x05 ///< CD/DVD device > +#define EFI_SCSI_TYPE_SCANNER 0x06 ///< Scanner device (obsole= te) > +#define EFI_SCSI_TYPE_OPTICAL 0x07 ///< Optical memory device = (e.g. > some optical disks) > +#define EFI_SCSI_TYPE_MEDIUMCHANGER 0x08 ///< Medium changer > device (e.g. jukeboxes) > +#define EFI_SCSI_TYPE_COMMUNICATION 0x09 ///< Communications > device (obsolete) > +#define EFI_SCSI_TYPE_ASCIT8_1 0x0A ///< Defined by ASC IT8 > (Graphic arts pre-press devices) > +#define EFI_SCSI_TYPE_ASCIT8_2 0x0B ///< Defined by ASC IT8 > (Graphic arts pre-press devices) > +#define EFI_SCSI_TYPE_RAID 0x0C ///< Storage array controll= er > device (e.g., RAID) > +#define EFI_SCSI_TYPE_SES 0x0D ///< Enclosure services dev= ice > +#define EFI_SCSI_TYPE_RBC 0x0E ///< Simplified direct-acce= ss device > (e.g., magnetic disk) > +#define EFI_SCSI_TYPE_OCRW 0x0F ///< Optical card reader/wr= iter > device > +#define EFI_SCSI_TYPE_BRIDGE 0x10 ///< Bridge Controller Comm= ands > +#define EFI_SCSI_TYPE_OSD 0x11 ///< Object-based Storage D= evice > +#define EFI_SCSI_TYPE_AUTOMATION 0x12 ///< Automation/Drive > Interface > +#define EFI_SCSI_TYPE_SECURITYMANAGER 0x13 ///< Security manager > device > +#define EFI_SCSI_TYPE_RESERVED_LOW 0x14 ///< Reserved (low) > +#define EFI_SCSI_TYPE_RESERVED_HIGH 0x1D ///< Reserved (high) > +#define EFI_SCSI_TYPE_WLUN 0x1E ///< Well known logical uni= t > +#define EFI_SCSI_TYPE_UNKNOWN 0x1F ///< Unknown or no device > type >=20 > // > // Page Codes for INQUIRY command > diff --git a/MdePkg/Include/Library/UefiScsiLib.h > b/MdePkg/Include/Library/UefiScsiLib.h > index 10dd81902b..5c94b0aa16 100644 > --- a/MdePkg/Include/Library/UefiScsiLib.h > +++ b/MdePkg/Include/Library/UefiScsiLib.h > @@ -5,7 +5,7 @@ > for hard drive, CD and DVD devices that are the most common SCSI boot > targets used by UEFI platforms. > This library class depends on SCSI I/O Protocol defined in UEFI Speci= fication > and SCSI-2 industry standard. >=20 > -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -813,6 +813,132 @@ ScsiWrite16Command ( > ); >=20 >=20 > +/** > + Execute Security Protocol In SCSI command on a specific SCSI target. > + > + Executes the SCSI Security Protocol In command on the SCSI target > specified by ScsiIo. > + If Timeout is zero, then this function waits indefinitely for the com= mand to > complete. > + If Timeout is greater than zero, then the command is executed and wil= l > timeout after > + Timeout 100 ns units. > + If ScsiIo is NULL, then ASSERT(). > + If SenseDataLength is NULL, then ASSERT(). > + If HostAdapterStatus is NULL, then ASSERT(). > + If TargetStatus is NULL, then ASSERT(). > + If TransferLength is NULL, then ASSERT(). > + > + If SenseDataLength is non-zero and SenseData is not NULL, SenseData > must meet buffer > + alignment requirement defined in EFI_SCSI_IO_PROTOCOL. Otherwise > EFI_INVALID_PARAMETER > + gets returned. > + > + If DataLength is non-zero and DataBuffer is not NULL, DataBuffer must > meet buffer > + alignment requirement defined in EFI_SCSI_IO_PROTOCOL. Otherwise > EFI_INVALID_PARAMETER > + gets returned. > + > + @param[in] ScsiIo SCSI IO Protocol to use. > + @param[in] Timeout The length of timeout perio= d. > + @param[in, out] SenseData A pointer to output sense d= ata. > + @param[in, out] SenseDataLength The length of output sense = data. > + @param[out] HostAdapterStatus The status of Host Adapter. > + @param[out] TargetStatus The status of the target. > + @param[in] SecurityProtocol The Security Protocol to us= e. > + @param[in] SecurityProtocolSpecific The Security Protocol Speci= fic data. > + @param[in] Inc512 If Inc512 is TRUE, DataLeng= th is expressed > in 512-byte increments. > + @param[in] DataLength The size in bytes of the da= ta buffer. > + @param[in, out] DataBuffer A pointer to a data buffer. > + @param[out] TransferLength A pointer to a buffer to st= ore the size > in > + bytes of the data written t= o the data buffer. > + > + @retval EFI_SUCCESS Command is executed successfully= . > + @retval EFI_BAD_BUFFER_SIZE The SCSI Request Packet was > executed, but the entire DataBuffer could > + not be transferred. The actual n= umber of bytes > transferred is returned in TransferLength. > + @retval EFI_NOT_READY The SCSI Request Packet could no= t be > sent because there are too many > + SCSI Command Packets already que= ued. > + @retval EFI_DEVICE_ERROR A device error occurred while > attempting to send SCSI Request Packet. > + @retval EFI_UNSUPPORTED The command described by the SCS= I > Request Packet is not supported by > + the SCSI initiator(i.e., SCSI H= ost Controller) > + @retval EFI_TIMEOUT A timeout occurred while waiting= for the > SCSI Request Packet to execute. > + @retval EFI_INVALID_PARAMETER The contents of the SCSI Request > Packet are invalid. > + > +**/ > +EFI_STATUS > +EFIAPI > +ScsiSecurityProtocolInCommand ( > + IN EFI_SCSI_IO_PROTOCOL *ScsiIo, > + IN UINT64 Timeout, > + IN OUT VOID *SenseData, OPTIONAL > + IN OUT UINT8 *SenseDataLength, > + OUT UINT8 *HostAdapterStatus, > + OUT UINT8 *TargetStatus, > + IN UINT8 SecurityProtocol, > + IN UINT16 SecurityProtocolSpecific, > + IN BOOLEAN Inc512, > + IN UINTN DataLength, > + IN OUT VOID *DataBuffer, OPTIONAL > + OUT UINTN *TransferLength > + ); > + > + > +/** > + Execute Security Protocol Out SCSI command on a specific SCSI target. > + > + Executes the SCSI Security Protocol Out command on the SCSI target > specified by ScsiIo. > + If Timeout is zero, then this function waits indefinitely for the com= mand to > complete. > + If Timeout is greater than zero, then the command is executed and wil= l > timeout after > + Timeout 100 ns units. > + If ScsiIo is NULL, then ASSERT(). > + If SenseDataLength is NULL, then ASSERT(). > + If HostAdapterStatus is NULL, then ASSERT(). > + If TargetStatus is NULL, then ASSERT(). > + > + If SenseDataLength is non-zero and SenseData is not NULL, SenseData > must meet buffer > + alignment requirement defined in EFI_SCSI_IO_PROTOCOL. Otherwise > EFI_INVALID_PARAMETER > + gets returned. > + > + If DataLength is non-zero and DataBuffer is not NULL, DataBuffer must > meet buffer > + alignment requirement defined in EFI_SCSI_IO_PROTOCOL. Otherwise > EFI_INVALID_PARAMETER > + gets returned. > + > + @param[in] ScsiIo SCSI IO Protocol to use. > + @param[in] Timeout The length of timeout perio= d. > + @param[in, out] SenseData A pointer to output sense d= ata. > + @param[in, out] SenseDataLength The length of output sense = data. > + @param[out] HostAdapterStatus The status of Host Adapter. > + @param[out] TargetStatus The status of the target. > + @param[in] SecurityProtocol The Security Protocol to us= e. > + @param[in] SecurityProtocolSpecific The Security Protocol Speci= fic data. > + @param[in] Inc512 If Inc512 is TRUE, DataLeng= th is expressed > in 512-byte increments. > + @param[in] DataLength The size in bytes of the tr= ansfer data. > + @param[in, out] DataBuffer A pointer to a data buffer. > + > + @retval EFI_SUCCESS Command is executed successfully= . > + @retval EFI_BAD_BUFFER_SIZE The SCSI Request Packet was > executed, but the entire DataBuffer could > + not be transferred. The actual n= umber of bytes > transferred is returned in DataLength. > + @retval EFI_NOT_READY The SCSI Request Packet could no= t be > sent because there are too many > + SCSI Command Packets already que= ued. > + @retval EFI_DEVICE_ERROR A device error occurred while > attempting to send SCSI Request Packet. > + @retval EFI_UNSUPPORTED The command described by the SCS= I > Request Packet is not supported by > + the SCSI initiator(i.e., SCSI H= ost Controller) > + @retval EFI_TIMEOUT A timeout occurred while waiting= for the > SCSI Request Packet to execute. > + @retval EFI_INVALID_PARAMETER The contents of the SCSI Request > Packet are invalid. > + > +**/ > +EFI_STATUS > +EFIAPI > +ScsiSecurityProtocolOutCommand ( > + IN EFI_SCSI_IO_PROTOCOL *ScsiIo, > + IN UINT64 Timeout, > + IN OUT VOID *SenseData, OPTIONAL > + IN OUT UINT8 *SenseDataLength, > + OUT UINT8 *HostAdapterStatus, > + OUT UINT8 *TargetStatus, > + IN UINT8 SecurityProtocol, > + IN UINT16 SecurityProtocolSpecific, > + IN BOOLEAN Inc512, > + IN UINTN DataLength, > + IN OUT VOID *DataBuffer OPTIONAL > + ); > + > + > /** > Execute blocking/non-blocking Read(10) SCSI command on a specific SCS= I > target. > diff --git a/MdePkg/Library/UefiScsiLib/UefiScsiLib.c > b/MdePkg/Library/UefiScsiLib/UefiScsiLib.c > index c7491d1436..229fe11ef2 100644 > --- a/MdePkg/Library/UefiScsiLib/UefiScsiLib.c > +++ b/MdePkg/Library/UefiScsiLib/UefiScsiLib.c > @@ -1,7 +1,7 @@ > /** @file > UEFI SCSI Library implementation >=20 > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved. > + Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -23,6 +23,7 @@ > // > #define EFI_SCSI_OP_LENGTH_SIX 0x6 > #define EFI_SCSI_OP_LENGTH_TEN 0xa > +#define EFI_SCSI_OP_LENGTH_TWELVE 0xc > #define EFI_SCSI_OP_LENGTH_SIXTEEN 0x10 >=20 > // > @@ -1280,6 +1281,220 @@ ScsiWrite16Command ( > } >=20 >=20 > +/** > + Execute Security Protocol In SCSI command on a specific SCSI target. > + > + Executes the SCSI Security Protocol In command on the SCSI target > specified by ScsiIo. > + If Timeout is zero, then this function waits indefinitely for the com= mand to > complete. > + If Timeout is greater than zero, then the command is executed and wil= l > timeout after > + Timeout 100 ns units. > + If ScsiIo is NULL, then ASSERT(). > + If SenseDataLength is NULL, then ASSERT(). > + If HostAdapterStatus is NULL, then ASSERT(). > + If TargetStatus is NULL, then ASSERT(). > + If TransferLength is NULL, then ASSERT(). > + > + If SenseDataLength is non-zero and SenseData is not NULL, SenseData > must meet buffer > + alignment requirement defined in EFI_SCSI_IO_PROTOCOL. Otherwise > EFI_INVALID_PARAMETER > + gets returned. > + > + If DataLength is non-zero and DataBuffer is not NULL, DataBuffer must > meet buffer > + alignment requirement defined in EFI_SCSI_IO_PROTOCOL. Otherwise > EFI_INVALID_PARAMETER > + gets returned. > + > + @param[in] ScsiIo SCSI IO Protocol to use. > + @param[in] Timeout The length of timeout perio= d. > + @param[in, out] SenseData A pointer to output sense d= ata. > + @param[in, out] SenseDataLength The length of output sense = data. > + @param[out] HostAdapterStatus The status of Host Adapter. > + @param[out] TargetStatus The status of the target. > + @param[in] SecurityProtocol The Security Protocol to us= e. > + @param[in] SecurityProtocolSpecific The Security Protocol Speci= fic data. > + @param[in] Inc512 If Inc512 is TRUE, DataLeng= th is expressed > in 512-byte increments. > + @param[in] DataLength The size in bytes of the da= ta buffer. > + @param[in, out] DataBuffer A pointer to a data buffer. > + @param[out] TransferLength A pointer to a buffer to st= ore the size > in > + bytes of the data written t= o the data buffer. > + > + @retval EFI_SUCCESS Command is executed successfully= . > + @retval EFI_BAD_BUFFER_SIZE The SCSI Request Packet was > executed, but the entire DataBuffer could > + not be transferred. The actual n= umber of bytes > transferred is returned in TransferLength. > + @retval EFI_NOT_READY The SCSI Request Packet could no= t be > sent because there are too many > + SCSI Command Packets already que= ued. > + @retval EFI_DEVICE_ERROR A device error occurred while > attempting to send SCSI Request Packet. > + @retval EFI_UNSUPPORTED The command described by the SCS= I > Request Packet is not supported by > + the SCSI initiator(i.e., SCSI H= ost Controller) > + @retval EFI_TIMEOUT A timeout occurred while waiting= for the > SCSI Request Packet to execute. > + @retval EFI_INVALID_PARAMETER The contents of the SCSI Request > Packet are invalid. > + > +**/ > +EFI_STATUS > +EFIAPI > +ScsiSecurityProtocolInCommand ( > + IN EFI_SCSI_IO_PROTOCOL *ScsiIo, > + IN UINT64 Timeout, > + IN OUT VOID *SenseData, OPTIONAL > + IN OUT UINT8 *SenseDataLength, > + OUT UINT8 *HostAdapterStatus, > + OUT UINT8 *TargetStatus, > + IN UINT8 SecurityProtocol, > + IN UINT16 SecurityProtocolSpecific, > + IN BOOLEAN Inc512, > + IN UINTN DataLength, > + IN OUT VOID *DataBuffer, OPTIONAL > + OUT UINTN *TransferLength > + ) > +{ > + EFI_SCSI_IO_SCSI_REQUEST_PACKET CommandPacket; > + EFI_STATUS Status; > + UINT8 Cdb[EFI_SCSI_OP_LENGTH_TWELVE]; > + > + ASSERT (SenseDataLength !=3D NULL); > + ASSERT (HostAdapterStatus !=3D NULL); > + ASSERT (TargetStatus !=3D NULL); > + ASSERT (ScsiIo !=3D NULL); > + ASSERT (TransferLength !=3D NULL); > + ASSERT (DataLength <=3D MAX_UINT32); > + > + ZeroMem (&CommandPacket, sizeof > (EFI_SCSI_IO_SCSI_REQUEST_PACKET)); > + ZeroMem (Cdb, EFI_SCSI_OP_LENGTH_TWELVE); > + > + CommandPacket.Timeout =3D Timeout; > + CommandPacket.InDataBuffer =3D DataBuffer; > + CommandPacket.SenseData =3D SenseData; > + CommandPacket.InTransferLength =3D (UINT32) DataLength; I think if 'Inc512' is TRUE, the above statement may not be proper. My thought is that the 'Inc512' parameter only affects whether the Cdb[4] = bit 7 will be set or not: @param[in] Inc512 If TRUE, 512 increment (INC_512) bit will be set for th= e SECURITY PROTOCOL IN command. and for Cdb[6]: if (Inc512) { if (DataLength % 512 !=3D 0) { return EFI_INVALID_PARAMETER; } Cdb[4] =3D BIT7; WriteUnaligned32 ((UINT32 *)&Cdb[6], SwapBytes32 ((UINT32) DataLength = / 512)); } else { WriteUnaligned32 ((UINT32 *)&Cdb[6], SwapBytes32 ((UINT32) DataLength)= ); } Similar comment for the function ScsiSecurityProtocolOutCommand() as well. Other than this, the patch looks good to me. Best Regards, Hao Wu > + CommandPacket.Cdb =3D Cdb; > + // > + // Fill Cdb for Security Protocol In Command > + // > + Cdb[0] =3D EFI_SCSI_OP_SECURITY_PROTOCOL_IN; > + Cdb[1] =3D SecurityProtocol; > + WriteUnaligned16 ((UINT16 *)&Cdb[2], SwapBytes16 > (SecurityProtocolSpecific)); > + WriteUnaligned32 ((UINT32 *)&Cdb[6], SwapBytes32 ((UINT32) > DataLength)); > + > + if (Inc512) { > + Cdb[4] =3D BIT7; > + } > + > + CommandPacket.CdbLength =3D EFI_SCSI_OP_LENGTH_TWELVE; > + CommandPacket.DataDirection =3D EFI_SCSI_DATA_IN; > + CommandPacket.SenseDataLength =3D *SenseDataLength; > + > + Status =3D ScsiIo->ExecuteScsiCommand (ScsiIo, > &CommandPacket, NULL); > + > + *HostAdapterStatus =3D CommandPacket.HostAdapterStatus; > + *TargetStatus =3D CommandPacket.TargetStatus; > + *SenseDataLength =3D CommandPacket.SenseDataLength; > + *TransferLength =3D (UINTN) CommandPacket.InTransferLen= gth; > + > + return Status; > +} > + > + > +/** > + Execute Security Protocol Out SCSI command on a specific SCSI target. > + > + Executes the SCSI Security Protocol Out command on the SCSI target > specified by ScsiIo. > + If Timeout is zero, then this function waits indefinitely for the com= mand to > complete. > + If Timeout is greater than zero, then the command is executed and wil= l > timeout after > + Timeout 100 ns units. > + If ScsiIo is NULL, then ASSERT(). > + If SenseDataLength is NULL, then ASSERT(). > + If HostAdapterStatus is NULL, then ASSERT(). > + If TargetStatus is NULL, then ASSERT(). > + > + If SenseDataLength is non-zero and SenseData is not NULL, SenseData > must meet buffer > + alignment requirement defined in EFI_SCSI_IO_PROTOCOL. Otherwise > EFI_INVALID_PARAMETER > + gets returned. > + > + If DataLength is non-zero and DataBuffer is not NULL, DataBuffer must > meet buffer > + alignment requirement defined in EFI_SCSI_IO_PROTOCOL. Otherwise > EFI_INVALID_PARAMETER > + gets returned. > + > + @param[in] ScsiIo SCSI IO Protocol to use. > + @param[in] Timeout The length of timeout perio= d. > + @param[in, out] SenseData A pointer to output sense d= ata. > + @param[in, out] SenseDataLength The length of output sense = data. > + @param[out] HostAdapterStatus The status of Host Adapter. > + @param[out] TargetStatus The status of the target. > + @param[in] SecurityProtocol The Security Protocol to us= e. > + @param[in] SecurityProtocolSpecific The Security Protocol Speci= fic data. > + @param[in] Inc512 If Inc512 is TRUE, DataLeng= th is expressed > in 512-byte increments. > + @param[in] DataLength The size in bytes of the tr= ansfer data. > + @param[in, out] DataBuffer A pointer to a data buffer. > + > + @retval EFI_SUCCESS Command is executed successfully= . > + @retval EFI_BAD_BUFFER_SIZE The SCSI Request Packet was > executed, but the entire DataBuffer could > + not be transferred. The actual n= umber of bytes > transferred is returned in DataLength. > + @retval EFI_NOT_READY The SCSI Request Packet could no= t be > sent because there are too many > + SCSI Command Packets already que= ued. > + @retval EFI_DEVICE_ERROR A device error occurred while > attempting to send SCSI Request Packet. > + @retval EFI_UNSUPPORTED The command described by the SCS= I > Request Packet is not supported by > + the SCSI initiator(i.e., SCSI H= ost Controller) > + @retval EFI_TIMEOUT A timeout occurred while waiting= for the > SCSI Request Packet to execute. > + @retval EFI_INVALID_PARAMETER The contents of the SCSI Request > Packet are invalid. > + > +**/ > +EFI_STATUS > +EFIAPI > +ScsiSecurityProtocolOutCommand ( > + IN EFI_SCSI_IO_PROTOCOL *ScsiIo, > + IN UINT64 Timeout, > + IN OUT VOID *SenseData, OPTIONAL > + IN OUT UINT8 *SenseDataLength, > + OUT UINT8 *HostAdapterStatus, > + OUT UINT8 *TargetStatus, > + IN UINT8 SecurityProtocol, > + IN UINT16 SecurityProtocolSpecific, > + IN BOOLEAN Inc512, > + IN UINTN DataLength, > + IN OUT VOID *DataBuffer OPTIONAL > + ) > +{ > + EFI_SCSI_IO_SCSI_REQUEST_PACKET CommandPacket; > + EFI_STATUS Status; > + UINT8 Cdb[EFI_SCSI_OP_LENGTH_TWELVE]; > + > + ASSERT (SenseDataLength !=3D NULL); > + ASSERT (HostAdapterStatus !=3D NULL); > + ASSERT (TargetStatus !=3D NULL); > + ASSERT (ScsiIo !=3D NULL); > + ASSERT (DataLength <=3D MAX_UINT32); > + > + ZeroMem (&CommandPacket, sizeof > (EFI_SCSI_IO_SCSI_REQUEST_PACKET)); > + ZeroMem (Cdb, EFI_SCSI_OP_LENGTH_TWELVE); > + > + CommandPacket.Timeout =3D Timeout; > + CommandPacket.OutDataBuffer =3D DataBuffer; > + CommandPacket.SenseData =3D SenseData; > + CommandPacket.OutTransferLength =3D (UINT32) DataLength; > + CommandPacket.Cdb =3D Cdb; > + // > + // Fill Cdb for Security Protocol Out Command > + // > + Cdb[0] =3D EFI_SCSI_OP_SECURITY_PROTOCOL_OUT; > + Cdb[1] =3D SecurityProtocol; > + WriteUnaligned16 ((UINT16 *)&Cdb[2], SwapBytes16 > (SecurityProtocolSpecific)); > + WriteUnaligned32 ((UINT32 *)&Cdb[6], SwapBytes32 ((UINT32) > DataLength)); > + > + if (Inc512) { > + Cdb[4] =3D BIT7; > + } > + > + CommandPacket.CdbLength =3D EFI_SCSI_OP_LENGTH_TWELVE; > + CommandPacket.DataDirection =3D EFI_SCSI_DATA_OUT; > + CommandPacket.SenseDataLength =3D *SenseDataLength; > + > + Status =3D ScsiIo->ExecuteScsiCommand (ScsiIo, > &CommandPacket, NULL); > + > + *HostAdapterStatus =3D CommandPacket.HostAdapterStatus; > + *TargetStatus =3D CommandPacket.TargetStatus; > + *SenseDataLength =3D CommandPacket.SenseDataLength; > + > + return Status; > +} > + > + > /** > Internal helper notify function in which update the result of the > non-blocking SCSI Read/Write commands and signal caller event. > -- > 2.16.2.windows.1 >=20 >=20 >=20