From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 11 Sep 2019 19:42:43 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 19:42:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,495,1559545200"; d="scan'208";a="186001900" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 11 Sep 2019 19:42:41 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Sep 2019 19:42:41 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Sep 2019 19:42:41 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Thu, 12 Sep 2019 10:42:39 +0800 From: "Wu, Hao A" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Ni, Ray" Subject: Re: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console Thread-Topic: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console Thread-Index: AQHVaQXzYm9M/iJZ6keCi6HpFLPZF6cnTtZw Date: Thu, 12 Sep 2019 02:42:39 +0000 Message-ID: References: <20190912010231.19544-1-zhichao.gao@intel.com> <20190912010231.19544-2-zhichao.gao@intel.com> In-Reply-To: <20190912010231.19544-2-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, September 12, 2019 9:02 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray > Subject: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of > Terminal console Hello, Entend -> Extend >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2186 >=20 > A common terminal console software Putty support various types of > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400, > VT100+ and SCO. Refer to the link: > https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config- > funkeys >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Zhichao Gao > --- > .../Include/Guid/TerminalConExtendedType.h | 25 > +++++++++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 6 +++++ > 2 files changed, 31 insertions(+) > create mode 100644 > MdeModulePkg/Include/Guid/TerminalConExtendedType.h >=20 > diff --git a/MdeModulePkg/Include/Guid/TerminalConExtendedType.h > b/MdeModulePkg/Include/Guid/TerminalConExtendedType.h > new file mode 100644 > index 0000000000..18667413e8 > --- /dev/null > +++ b/MdeModulePkg/Include/Guid/TerminalConExtendedType.h > @@ -0,0 +1,25 @@ > +/** @file > + GUID definition for Linux, XtermR6, Vt400 and SCO terminal type. > + > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef __TERMINAL_CON_EXTENDED_TYPE_H__ > +#define __TERMINAL_CON_EXTENDED_TYPE_H__ > + > +#define EDKII_LINUX_MODE_GUID \ > + { 0xe4364a7f, 0xf825, 0x430e, { 0x9d, 0x3a, 0x9c, 0x9b, 0xe6, 0x81, = 0x7c, > 0xa5 } } > + > +#define EDKII_XTERM_R6_GUID \ > + { 0xfbfca56b, 0xbb36, 0x4b78, { 0xaa, 0xab, 0xbe, 0x1b, 0x97, 0xec, = 0x7c, > 0xcb } } > + > +#define EDKII_VT400_GUID \ > + { 0x8e46dddd, 0x3d49, 0x4a9d, { 0xb8, 0x75, 0x3c, 0x08, 0x6f, 0x6a, = 0xa2, > 0xbd } } > + > +#define EDKII_SCO_GUID \ > + { 0xfc7dd6e0, 0x813c, 0x434d, { 0xb4, 0xda, 0x3b, 0xd6, 0x49, 0xe9, = 0xe1, > 0x5a } } > + I would suggest to add corresponding GUID declarations just as what has bee= n done in: MdePkg/Include/Guid/PcAnsi.h MdeModulePkg/Include/Guid/TtyTerm.h > +#endif > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 17beb45235..7528d52fcb 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -343,6 +343,12 @@ > ## Include/Guid/TtyTerm.h > gEfiTtyTermGuid =3D { 0x7d916d80, 0x5bb1, 0x458c, {0xa4= , 0x8f, 0xe2, > 0x5f, 0xdd, 0x51, 0xef, 0x94 }} >=20 > + ## Include/Guid/TerminalConExtendedType.h > + gEdkiiLinuxModeGuid =3D { 0xe4364a7f, 0xf825, 0x430e, { 0x9d= , 0x3a, > 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 } } > + gEdkiiXtermR6Guid =3D { 0xfbfca56b, 0xbb36, 0x4b78, { 0xaa= , 0xab, > 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb } } > + gEdkiiVT400Guid =3D { 0x8e46dddd, 0x3d49, 0x4a9d, { 0xb8= , 0x75, 0x3c, > 0x08, 0x6f, 0x6a, 0xa2, 0xbd } } > + gEdkiiSCOGuid =3D { 0xfc7dd6e0, 0x813c, 0x434d, { 0xb4= , 0xda, 0x3b, > 0xd6, 0x49, 0xe9, 0xe1, 0x5a } } > + After this patch, there will be 3 header files that describe different term= inal modes supported in TerminalDxe driver: MdePkg/Include/Guid/PcAnsi.h (PcAnsi, VT100, VT100+, VTUTF8) MdeModulePkg/Include/Guid/TtyTerm.h (TtyTerm) MdeModulePkg/Include/Guid/TerminalConExtendedType.h (Linux, Xterm R6, Vt400= , SCO) Do we have a plan to add those 5 non-UEFI modes in the UEFI spec? If not, I am wondering is it possible to at least merge TtyTerm.h and TerminalConExtendedType.h into one file so that we can avoid introducing ne= w header files every time new terminal modes are being added. Best Regards, Hao Wu > ## Include/Guid/HiiBootMaintenanceFormset.h > gEfiIfrBootMaintenanceGuid =3D { 0xb2dedc91, 0xd59f, 0x48d2, { 0x= 89, 0x8a, > 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} >=20 > -- > 2.21.0.windows.1