From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Wed, 18 Sep 2019 18:54:40 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 18:54:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,522,1559545200"; d="scan'208";a="388127849" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 18 Sep 2019 18:54:39 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 18:54:39 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 18:54:38 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.89]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 09:54:36 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Wang, Jian J" , "Ni, Ray" , "Ard Biesheuvel" , Laszlo Ersek , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the support keyboard type of Terminal console Thread-Topic: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the support keyboard type of Terminal console Thread-Index: AQHVbeKz6bsrGq2qrkeX+9iVRIC5xacyPeHA Date: Thu, 19 Sep 2019 01:54:36 +0000 Message-ID: References: <20190918053355.19892-1-zhichao.gao@intel.com> <20190918053355.19892-2-zhichao.gao@intel.com> In-Reply-To: <20190918053355.19892-2-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Wednesday, September 18, 2019 1:34 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Ard Biesheuvel; Laszlo Ersek; Gao,= Liming > Subject: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the support > keyboard type of Terminal console >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2186 >=20 > A common terminal console software Putty support various types of > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400, > VT100+ and SCO. Refer to the link: > https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config- > funkeys >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > MdeModulePkg/Include/Guid/TtyTerm.h | 13 +++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > 2 files changed, 17 insertions(+) >=20 > diff --git a/MdeModulePkg/Include/Guid/TtyTerm.h > b/MdeModulePkg/Include/Guid/TtyTerm.h > index 8333344b9d..471a651d4d 100644 > --- a/MdeModulePkg/Include/Guid/TtyTerm.h > +++ b/MdeModulePkg/Include/Guid/TtyTerm.h > @@ -4,6 +4,7 @@ provide support for modern *nix terminals. >=20 >=20 > Copyright (c) 2015 Linaro Ltd. > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -14,6 +15,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #define EFI_TTY_TERM_GUID \ > {0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0= xef, > 0x94 } } >=20 > +#define EDKII_LINUX_TERM_GUID \ > + {0xe4364a7f, 0xf825, 0x430e, {0x9d, 0x3a, 0x9c, 0x9b, 0xe6, 0x81, 0= x7c, > 0xa5 } } > + > +#define EDKII_XTERM_R6_GUID \ > + {0xfbfca56b, 0xbb36, 0x4b78, {0xaa, 0xab, 0xbe, 0x1b, 0x97, 0xec, 0= x7c, > 0xcb } } > + > +#define EDKII_VT400_GUID \ > + {0x8e46dddd, 0x3d49, 0x4a9d, {0xb8, 0x75, 0x3c, 0x08, 0x6f, 0x6a, 0= xa2, > 0xbd } } > + > +#define EDKII_SCO_TERM_GUID \ > + {0xfc7dd6e0, 0x813c, 0x434d, {0xb4, 0xda, 0x3b, 0xd6, 0x49, 0xe9, 0= xe1, > 0x5a } } > + > extern EFI_GUID gEfiTtyTermGuid; >=20 > #endif > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 17beb45235..7f72c122fc 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -342,6 +342,10 @@ >=20 > ## Include/Guid/TtyTerm.h > gEfiTtyTermGuid =3D { 0x7d916d80, 0x5bb1, 0x458c, {0xa= 4, 0x8f, 0xe2, > 0x5f, 0xdd, 0x51, 0xef, 0x94 }} > + gEdkiiLinuxTermGuid =3D { 0xe4364a7f, 0xf825, 0x430e, {0x9= d, 0x3a, > 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 }} > + gEdkiiXtermR6Guid =3D { 0xfbfca56b, 0xbb36, 0x4b78, {0xa= a, 0xab, > 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb }} > + gEdkiiVT400Guid =3D { 0x8e46dddd, 0x3d49, 0x4a9d, {0xb= 8, 0x75, 0x3c, > 0x08, 0x6f, 0x6a, 0xa2, 0xbd }} > + gEdkiiSCOTermGuid =3D { 0xfc7dd6e0, 0x813c, 0x434d, {0xb= 4, 0xda, > 0x3b, 0xd6, 0x49, 0xe9, 0xe1, 0x5a }} Since these 4 new GUIDs are listed under comments for file 'TtyTerm.h', I = would suggest to add these variable declarations in TtyTerm.h: extern EFI_GUID gEdkiiLinuxTermGuid; extern EFI_GUID gEdkiiXtermR6Guid; extern EFI_GUID gEdkiiVT400Guid; extern EFI_GUID gEdkiiSCOTermGuid; With this handled, Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > ## Include/Guid/HiiBootMaintenanceFormset.h > gEfiIfrBootMaintenanceGuid =3D { 0xb2dedc91, 0xd59f, 0x48d2, { 0= x89, 0x8a, > 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} > -- > 2.21.0.windows.1 >=20 >=20 >=20