From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 18 Sep 2019 18:57:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 18:57:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,522,1559545200"; d="scan'208";a="217143633" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 18 Sep 2019 18:57:04 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 18:57:04 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 18 Sep 2019 18:57:03 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 18 Sep 2019 18:57:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.235]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 09:57:01 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Gao, Zhichao" , "Ni, Ray" , "Bi, Dandan" , "Dong, Eric" CC: "Wang, Jian J" , Ard Biesheuvel , Laszlo Ersek , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH V3 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types Thread-Topic: [edk2-devel] [PATCH V3 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types Thread-Index: AQHVbeKy9n2c2cYdMkabJhxlcfHxSacyPv6g Date: Thu, 19 Sep 2019 01:57:01 +0000 Message-ID: References: <20190918053355.19892-1-zhichao.gao@intel.com> In-Reply-To: <20190918053355.19892-1-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Wednesday, September 18, 2019 1:34 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Ard Biesheuvel; Laszlo Ersek; Gao,= Liming > Subject: [edk2-devel] [PATCH V3 0/3] MdeModulePkg/TerminalConsole: > Extend the support terminal types >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2186 >=20 > Putty is a very popular terminal tool in windows. So add the whole suppo= rt > terminal keyboard type for it. The new introduced type is Linux, XtermR6= , > VT400 and SCO. And enhance the support for VT100+. > This patch set only add the support of function key. Refer to the link: > https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config- > funkeys >=20 > V2: > Fix typo. > Merge the type guid defination into TtyTerm.h. >=20 > V3: > Fix incorrect removal of Ttyterm parse. > Change the guid name of terminal type linux and SCO to clear ones: > LinuxTerm and SCOTerm. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Liming Gao > Signed-of-by: Zhichao Gao >=20 > Zhichao Gao (3): > MdeModulePkg: Extend the support keyboard type of Terminal console > MdeModulePkg/TerminalDxe: Extend the terminal console support types > MdeModulePkg/BM_UI: Add the new terminal types to related menu I will leave patch 2 & 3 to Console & UI reviewers. Best Regards, Hao Wu >=20 > MdeModulePkg/Include/Guid/TtyTerm.h | 13 + > .../BootMaintenanceManager.h | 12 +- > .../BootMaintenanceManagerStrings.uni | 10 +- > .../ConsoleOption.c | 35 +-- > .../BootMaintenanceManagerUiLib/Data.c | 16 +- > MdeModulePkg/MdeModulePkg.dec | 4 + > .../Universal/Console/TerminalDxe/Terminal.c | 17 +- > .../Universal/Console/TerminalDxe/Terminal.h | 37 ++- > .../Console/TerminalDxe/TerminalConIn.c | 282 ++++++++++++++++-- > .../Console/TerminalDxe/TerminalConOut.c | 4 + > .../Console/TerminalDxe/TerminalDxe.inf | 6 +- > 11 files changed, 376 insertions(+), 60 deletions(-) >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20