From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Tue, 24 Sep 2019 06:01:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 06:01:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,544,1559545200"; d="scan'208";a="340074365" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 24 Sep 2019 06:01:46 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 06:01:45 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 06:01:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.86]) with mapi id 14.03.0439.000; Tue, 24 Sep 2019 21:01:44 +0800 From: "Wu, Hao A" To: =?iso-8859-1?Q?Marvin_H=E4user?= , "devel@edk2.groups.io" , "Gao, Zhichao" , "Ni, Ray" CC: "Wang, Jian J" Subject: Re: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX Thread-Topic: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX Thread-Index: AQHVctYMgCwkp9D70UqlPjNJoZy/TKc6ykZQ Date: Tue, 24 Sep 2019 13:01:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] > Sent: Tuesday, September 24, 2019 8:46 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider > SourceX >=20 > From: Marvin Haeuser >=20 > Currently, SourceX is not considered in the BufferToVideo operation > when the 8-bit pixel format is used. Correctly add the resulting > offset to prevent image corruption. >=20 > Cc: Jian J Wang > Cc: Hao A Wu Hello Marvin, In the future, could you help to run the below script: BaseTools/Scripts/GetMaintainer.py to get the reviewers for the proposed patch? Thanks in advance. Hello Zhichao and Ray, Could you help to take a look at this patch? Thanks. Best Regards, Hao Wu > Signed-off-by: Marvin Haeuser > --- > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > index 47c5326e9958..a084cc81d32e 100644 > --- a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > +++ b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > @@ -504,7 +504,7 @@ FrameBufferBltLibBufferToVideo ( > Destination =3D Configure->FrameBuffer + Offset; >=20 >=20 >=20 > if (Configure->PixelFormat =3D=3D PixelBlueGreenRedReserved8BitPerCo= lor) { >=20 > - Source =3D (UINT8 *) BltBuffer + (SrcY * Delta); >=20 > + Source =3D (UINT8 *) BltBuffer + (SrcY * Delta) + (SourceX * sizeo= f > (EFI_GRAPHICS_OUTPUT_BLT_PIXEL)); >=20 > } else { >=20 > for (IndexX =3D 0; IndexX < Width; IndexX++) { >=20 > Blt =3D >=20 > -- > 2.23.0.windows.1